Massive file cleanup

NuGet.README.md

@@ -2,10 +2,10 @@
 
 MassTransit provides a developer-focused, modern platform for creating distributed applications without complexity.
 
-   - First class testing support
-   - Write once, then deploy using RabbitMQ, Azure Service Bus, and Amazon SQS
-   - Observability via Open Telemetry (OTEL)
-   - Fully-supported, widely-adopted, a complete end-to-end solution
+- First class testing support
+- Write once, then deploy using RabbitMQ, Azure Service Bus, and Amazon SQS
+- Observability via Open Telemetry (OTEL)
+- Fully-supported, widely-adopted, a complete end-to-end solution
 
 ## Documentation
 
@@ -112,14 +112,15 @@ The following packages from earlier versions of MassTransit are no longer suppor
 * MassTransit.StructureMapSigned
 * MassTransit.Unity
 
-## Discord 
+## Discord
 
 Get help live at the MassTransit Discord server.
 
 [![alt Join the conversation](https://img.shields.io/discord/682238261753675864.svg "Discord")](https://discord.gg/rNpQgYn)
 
 ## GitHub Issues
 
-> Please do not open an issue on GitHub, unless you have spotted an actual bug in MassTransit. 
+> Please do not open an issue on GitHub, unless you have spotted an actual bug in MassTransit.
 
-Use [GitHub Discussions](https://github.com/MassTransit/MassTransit/discussions) to ask questions, bring up ideas, or other general items. Issues are not the place for questions, and will either be converted to a discussion or closed.
+Use [GitHub Discussions](https://github.com/MassTransit/MassTransit/discussions) to ask questions, bring up ideas, or other general items. Issues are not the
+place for questions, and will either be converted to a discussion or closed.

src/MassTransit.Abstractions/Configuration/Configuration/ConsumerConfigurationObservable.cs

@@ -31,6 +31,5 @@ public void Method5()
         public void Method6()
         {
         }
-
     }
 }

src/MassTransit.Abstractions/Configuration/Configuration/EndpointConfigurationObservable.cs

@@ -24,6 +24,5 @@ public void Method5()
         public void Method6()
         {
         }
-
     }
 }

src/MassTransit.Abstractions/Configuration/Configuration/HandlerConfigurationObservable.cs

@@ -24,6 +24,5 @@ public void Method5()
         public void Method6()
         {
         }
-
     }
 }

src/MassTransit.Abstractions/Configuration/Configuration/SagaConfigurationObservable.cs

@@ -37,6 +37,5 @@ public void Method5()
         public void Method6()
         {
         }
-
     }
 }

src/MassTransit.Abstractions/Configuration/Configuration/ValueTypeGroupKeyProvider.cs

@@ -17,7 +17,7 @@ public ValueTypeGroupKeyProvider(Func<ConsumeContext<TMessage>, TKey?> provider)
 
         public bool TryGetKey(ConsumeContext<TMessage> context, out TKey key)
         {
-            var property = _provider(context);
+            TKey? property = _provider(context);
 
             if (property.HasValue)
             {

src/MassTransit.Abstractions/Configuration/Consumers/IBatchConfigurator.cs

@@ -37,7 +37,8 @@ public interface IBatchConfigurator<TMessage> :
         /// <param name="consumerFactory"></param>
         /// <param name="configure">Configure the consumer pipe</param>
         /// <typeparam name="TConsumer"></typeparam>
-        void Consumer<TConsumer>(IConsumerFactory<TConsumer> consumerFactory, Action<IConsumerMessageConfigurator<TConsumer, Batch<TMessage>>>? configure = null)
+        void Consumer<TConsumer>(IConsumerFactory<TConsumer> consumerFactory,
+            Action<IConsumerMessageConfigurator<TConsumer, Batch<TMessage>>>? configure = null)
             where TConsumer : class, IConsumer<Batch<TMessage>>;
     }
 }

src/MassTransit.Abstractions/Configuration/DependencyInjection/ActivityDefinition.cs

@@ -33,9 +33,9 @@ void IActivityDefinition<TActivity, TArguments, TLog>.Configure(IReceiveEndpoint
             if (ConcurrentMessageLimit.HasValue)
                 compensateActivityConfigurator.ConcurrentMessageLimit = ConcurrentMessageLimit;
 
-        #pragma warning disable CS0618
+            #pragma warning disable CS0618
             ConfigureCompensateActivity(endpointConfigurator, compensateActivityConfigurator);
-        #pragma warning restore CS0618
+            #pragma warning restore CS0618
             ConfigureCompensateActivity(endpointConfigurator, compensateActivityConfigurator, context);
         }
 

src/MassTransit.Abstractions/Configuration/DependencyInjection/ConsumerDefinition.cs

@@ -48,9 +48,9 @@ void IConsumerDefinition<TConsumer>.Configure(IReceiveEndpointConfigurator endpo
             if (_concurrentMessageLimit.HasValue)
                 consumerConfigurator.ConcurrentMessageLimit = _concurrentMessageLimit;
 
-        #pragma warning disable CS0618
+            #pragma warning disable CS0618
             ConfigureConsumer(endpointConfigurator, consumerConfigurator);
-        #pragma warning restore CS0618
+            #pragma warning restore CS0618
             ConfigureConsumer(endpointConfigurator, consumerConfigurator, context);
         }
 

src/MassTransit.Abstractions/Configuration/DependencyInjection/ExecuteActivityDefinition.cs

@@ -45,9 +45,9 @@ void IExecuteActivityDefinition<TActivity, TArguments>.Configure(IReceiveEndpoin
             if (_concurrentMessageLimit.HasValue)
                 executeActivityConfigurator.ConcurrentMessageLimit = _concurrentMessageLimit;
 
-        #pragma warning disable CS0618
+            #pragma warning disable CS0618
             ConfigureExecuteActivity(endpointConfigurator, executeActivityConfigurator);
-        #pragma warning restore CS0618
+            #pragma warning restore CS0618
             ConfigureExecuteActivity(endpointConfigurator, executeActivityConfigurator, context);
         }
 

src/MassTransit.Abstractions/Configuration/DependencyInjection/FutureDefinition.cs

@@ -49,9 +49,9 @@ void IFutureDefinition<TFuture>.Configure(IReceiveEndpointConfigurator endpointC
             if (_concurrentMessageLimit.HasValue)
                 sagaConfigurator.ConcurrentMessageLimit = _concurrentMessageLimit;
 
-        #pragma warning disable CS0618
+            #pragma warning disable CS0618
             ConfigureSaga(endpointConfigurator, sagaConfigurator);
-        #pragma warning restore CS0618
+            #pragma warning restore CS0618
             ConfigureSaga(endpointConfigurator, sagaConfigurator, context);
         }
 

src/MassTransit.Abstractions/Configuration/DependencyInjection/SagaDefinition.cs

@@ -49,9 +49,9 @@ void ISagaDefinition<TSaga>.Configure(IReceiveEndpointConfigurator endpointConfi
             if (_concurrentMessageLimit.HasValue)
                 sagaConfigurator.ConcurrentMessageLimit = _concurrentMessageLimit;
 
-        #pragma warning disable CS0618
+            #pragma warning disable CS0618
             ConfigureSaga(endpointConfigurator, sagaConfigurator);
-        #pragma warning restore CS0618
+            #pragma warning restore CS0618
             ConfigureSaga(endpointConfigurator, sagaConfigurator, context);
         }
 

src/MassTransit.Abstractions/Configuration/Topology/IMessageSendTopologyConfigurator.cs

@@ -1,8 +1,7 @@
-using System.Diagnostics.CodeAnalysis;
-
 namespace MassTransit
 {
     using System;
+    using System.Diagnostics.CodeAnalysis;
     using Configuration;
 
 

src/MassTransit.Abstractions/Contexts/Context/ResponseEndpointConverterCache.cs

@@ -2,7 +2,6 @@ namespace MassTransit.Context
 {
     using System;
     using System.Collections.Concurrent;
-    using System.Threading;
     using System.Threading.Tasks;
 
 
@@ -36,7 +35,7 @@ static IResponseEndpointConverter CreateConverter(Type type)
             var converterType = typeof(ResponseEndpointConverter<>).MakeGenericType(type);
 
             return Activator.CreateInstance(converterType) as IResponseEndpointConverter
-                   ?? throw new InvalidOperationException("Failed to create ResponseEndpointConverter");
+                ?? throw new InvalidOperationException("Failed to create ResponseEndpointConverter");
         }
 
 

src/MassTransit.Abstractions/Contexts/Context/SendContextScope.cs

@@ -2,7 +2,6 @@
 {
     using System;
     using System.Diagnostics.CodeAnalysis;
-    using System.Reflection;
     using System.Threading;
     using Payloads;
 

src/MassTransit.Abstractions/Contexts/Headers.cs

@@ -1,5 +1,4 @@
-#nullable enable
-namespace MassTransit
+namespace MassTransit
 {
     using System.Collections.Generic;
     using System.Diagnostics.CodeAnalysis;

src/MassTransit.Abstractions/Contexts/MessageBody.cs

@@ -1,4 +1,3 @@
-#nullable enable
 namespace MassTransit
 {
     using System.IO;

src/MassTransit.Abstractions/Contexts/ReceiveContextExtensions.cs

@@ -1,4 +1,3 @@
-#nullable enable
 namespace MassTransit
 {
     using System;

src/MassTransit.Abstractions/Contexts/SendContext.cs

@@ -1,5 +1,4 @@
-#nullable enable
-namespace MassTransit
+namespace MassTransit
 {
     using System;
     using System.Net.Mime;

src/MassTransit.Abstractions/Contexts/SerializerContext.cs

@@ -1,4 +1,3 @@
-#nullable enable
 namespace MassTransit
 {
     using System;

src/MassTransit.Abstractions/Contexts/TimeSpanContextScheduleExtensions.cs

@@ -227,7 +227,6 @@ public static Task<ScheduledMessage> ScheduleSend(this MessageSchedulerContext s
             return scheduler.ScheduleSend(scheduledTime, message, callback.ToPipe(), cancellationToken);
         }
 
-
         /// <summary>
         /// Sends an object as a message, using the message type specified. If the object cannot be cast
         /// to the specified message type, an exception will be thrown.

src/MassTransit.Abstractions/Internals/Extensions/InterfaceExtensions.cs

@@ -3,7 +3,6 @@
     using System;
     using System.Collections.Generic;
     using System.Linq;
-    using System.Reflection;
     using System.Threading.Tasks;
 
 
@@ -116,7 +115,7 @@ public static bool ClosesType(this Type type, Type openType, out Type? closedTyp
                     return false;
                 }
 
-                if (interfaceType is {IsGenericTypeDefinition: false, ContainsGenericParameters: false})
+                if (interfaceType is { IsGenericTypeDefinition: false, ContainsGenericParameters: false })
                 {
                     closedType = interfaceType;
                     return true;

src/MassTransit.Abstractions/Internals/Extensions/TaskExtensions.cs

@@ -254,7 +254,6 @@ public static void TrySetFromTask<T>(this TaskCompletionSource<T> source, Task<T
             }
         }
 
-
         /// <summary>
         /// Register a callback on the <paramref name="cancellationToken" /> which completes the resulting task.
         /// </summary>

src/MassTransit.Abstractions/Internals/Extensions/TypeExtensions.cs

@@ -34,7 +34,7 @@ public static IEnumerable<PropertyInfo> GetAllProperties(this TypeInfo typeInfo)
                     yield return prop;
             }
 
-            var specialGetPropertyNames = typeInfo.DeclaredMethods
+            IEnumerable<string>? specialGetPropertyNames = typeInfo.DeclaredMethods
                 .Where(x => x.IsSpecialName && x.Name.StartsWith("get_") && !x.IsStatic)
                 .Select(x => x.Name.Substring("get_".Length)).Distinct();
 
@@ -46,8 +46,8 @@ public static IEnumerable<PropertyInfo> GetAllProperties(this TypeInfo typeInfo)
             {
                 IEnumerable<PropertyInfo> sourceProperties = properties
                     .Concat(typeInfo.ImplementedInterfaces.SelectMany(x => x.GetProperties(BindingFlags.DeclaredOnly | BindingFlags.Instance |
-                                                                                           BindingFlags.Static | BindingFlags.Public |
-                                                                                           BindingFlags.NonPublic)));
+                        BindingFlags.Static | BindingFlags.Public |
+                        BindingFlags.NonPublic)));
 
                 foreach (var prop in sourceProperties)
                     yield return prop;
@@ -78,23 +78,22 @@ public static IEnumerable<PropertyInfo> GetAllStaticProperties(this Type type)
                     yield return prop;
             }
 
-            IEnumerable<PropertyInfo> props = info.DeclaredMethods
+            IEnumerable<PropertyInfo?> props = info.DeclaredMethods
                 .Where(x => x.IsSpecialName && x.Name.StartsWith("get_") && x.IsStatic)
-                .Select(x => info.GetDeclaredProperty(x.Name.Substring("get_".Length)))
-                .Cast<PropertyInfo>();
+                .Select(x => info.GetDeclaredProperty(x.Name.Substring("get_".Length)));
 
             foreach (var propertyInfo in props)
-                yield return propertyInfo;
+                if (propertyInfo != null)
+                    yield return propertyInfo;
         }
 
-        public static IEnumerable<PropertyInfo> GetStaticProperties(this Type type)
+        public static IEnumerable<PropertyInfo?> GetStaticProperties(this Type type)
         {
             var info = type.GetTypeInfo();
 
             return info.DeclaredMethods
                 .Where(x => x.IsSpecialName && x.Name.StartsWith("get_") && x.IsStatic)
-                .Select(x => info.GetDeclaredProperty(x.Name.Substring("get_".Length)))
-                .Cast<PropertyInfo>();
+                .Select(x => info.GetDeclaredProperty(x.Name.Substring("get_".Length)));
         }
 
         /// <summary>
@@ -175,8 +174,8 @@ public static bool IsOpenGeneric(this Type type)
         public static bool CanBeNull(this Type type)
         {
             return !type.IsValueType
-                   || type == typeof(string)
-                   || type.IsGenericType && type.GetGenericTypeDefinition() == typeof(Nullable<>);
+                || type == typeof(string)
+                || (type.IsGenericType && type.GetGenericTypeDefinition() == typeof(Nullable<>));
         }
 
         /// <summary>

src/MassTransit.Abstractions/Internals/Reflection/TypeNameFormatter.cs

@@ -2,7 +2,6 @@ namespace MassTransit.Internals
 {
     using System;
     using System.Collections.Concurrent;
-    using System.Reflection;
     using System.Text;
 
 

src/MassTransit.Abstractions/Licensing/LicenseContact.cs

@@ -5,4 +5,4 @@ public class LicenseContact
         public string? Name { get; set; }
         public string? Email { get; set; }
     }
-}
+}

src/MassTransit.Abstractions/Licensing/LicenseCustomer.cs

@@ -5,4 +5,4 @@ public class LicenseCustomer
         public string? Id { get; set; }
         public string? Name { get; set; }
     }
-}
+}

src/MassTransit.Abstractions/Licensing/LicenseFeature.cs

@@ -5,4 +5,4 @@ public class LicenseFeature
         public string? Name { get; set; }
         public string? Description { get; set; }
     }
-}
+}

src/MassTransit.Abstractions/Licensing/LicenseProduct.cs

@@ -11,4 +11,4 @@ public class LicenseProduct
         public DateTime? Expires { get; set; }
         public Dictionary<string, LicenseFeature>? Features { get; set; }
     }
-}
+}

src/MassTransit.Abstractions/MassTransit.Abstractions.csproj

@@ -1,5 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
-  <Import Project="../../signing.props" />
+  <Import Project="../../signing.props"/>
 
   <PropertyGroup>
     <TargetFrameworks>netstandard2.0;netstandard2.1;net6.0;net7.0;net8.0</TargetFrameworks>
@@ -20,14 +20,14 @@
   </PropertyGroup>
 
   <ItemGroup Condition=" '$(TargetFramework)' == 'net472' ">
-    <PackageReference Include="System.ValueTuple" />
+    <PackageReference Include="System.ValueTuple"/>
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="All" />
+    <PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="All"/>
   </ItemGroup>
 
   <ItemGroup>
-    <Folder Include="Futures\Futures" />
+    <Folder Include="Futures\Futures"/>
   </ItemGroup>
 </Project>