Make example makefiles more readable

druidfi · Aug 5, 2019 · 1a42292 · 1a42292
1 parent 69970bc
commit 1a42292
Show file tree

Hide file tree

Showing 5 changed files with 34 additions and 11 deletions.
diff --git a/examples/contentacms/Makefile b/examples/contentacms/Makefile
@@ -1,11 +1,18 @@
 .PHONY: app down help up
 .DEFAULT_GOAL := help
 
-DB_URL := mysql\://drupal\:drupal@127.0.0.1\:3306/drupal
+DRUPAL_DB_URL := mysql\://drupal\:drupal@127.0.0.1\:3306/drupal
+DRUPAL_PROFILE := contenta_jsonapi
+DRUPAL_SITENAME := Contenta CMS example
+DRUPAL_URL := http://contentacms.docker.sh
 
 app:
 	$(call colorecho, "\nCreate Contenta CMS project...")
-	@test -d contentacms && echo "Project folder already exists" || docker run --rm --interactive --tty --volume $(shell pwd):/app composer create-project contentacms/contenta-jsonapi-project --stability dev --no-interaction --remove-vcs --no-progress --prefer-dist --ignore-platform-reqs contentacms
+	@test -d contentacms && echo "Project folder already exists" || docker run --rm --interactive --tty \
+		--volume $(shell pwd):/app \
+		composer create-project contentacms/contenta-jsonapi-project \
+		--stability dev --no-interaction --remove-vcs --no-progress --prefer-dist --ignore-platform-reqs \
+		contentacms
 
 down: ## Tear down example Contenta CMS application
 	@docker-compose down -v
@@ -20,9 +27,11 @@ up: app ## Launch example Contenta CMS application
 	$(call colorecho, "\nStart Contenta CMS example application...")
 	@docker-compose up -d
 	$(call colorecho, "\nInstall site with Drush...")
-	@docker-compose exec contentacms drush -y site:install contenta_jsonapi --db-url=$(DB_URL) --site-name="Contenta CMS example"
+	@docker-compose exec contentacms drush -y site:install $(DRUPAL_PROFILE) \
+		--db-url=$(DRUPAL_DB_URL) \
+		--site-name="$(DRUPAL_SITENAME)"
 	@docker-compose exec contentacms drush en -y recipes_magazin contentajs
-	$(call colorecho, "\nDONE! Check http://contentacms.docker.sh ...\n")
+	$(call colorecho, "\nDONE! Check $(DRUPAL_URL) ...\n")
 
 define colorecho
     @tput -T xterm setaf 3

diff --git a/examples/drupal8/Makefile b/examples/drupal8/Makefile
@@ -1,11 +1,17 @@
 .PHONY: app down help up
 .DEFAULT_GOAL := help
 
-DB_URL := mysql\://drupal\:drupal@127.0.0.1\:3306/drupal
+DRUPAL_DB_URL := mysql\://drupal\:drupal@127.0.0.1\:3306/drupal
+DRUPAL_PROFILE := demo_umami
+DRUPAL_SITENAME := Drupal 8 example
+DRUPAL_URL := http://drupal8.docker.sh
 
 app:
 	$(call colorecho, "\nCreate Drupal 8 project to drupal folder")
-	@docker run --rm --interactive --tty --volume $(shell pwd):/app composer create-project drupal-composer/drupal-project --no-interaction --stability dev --ignore-platform-reqs drupal
+	@docker run --rm --interactive --tty \
+		--volume $(shell pwd):/app \
+		composer create-project drupal-composer/drupal-project --no-interaction --stability dev --ignore-platform-reqs \
+		drupal
 
 down: ## Tear down example Drupal 8 application
 	@docker-compose down -v
@@ -20,8 +26,10 @@ up: app ## Launch example Drupal 8 application
 	$(call colorecho, "\nStart Drupal 8 example application...")
 	@docker-compose up -d
 	$(call colorecho, "\nInstall site with Drush...")
-	@docker-compose exec drupal drush -y site:install demo_umami --db-url=$(DB_URL) --site-name="Drupal 8 example"
-	$(call colorecho, "\n- DONE! Check http://drupal8.docker.sh ...\n")
+	@docker-compose exec drupal drush -y site:install $(DRUPAL_PROFILE) \
+		--db-url=$(DRUPAL_DB_URL) \
+		--site-name="$(DRUPAL_SITENAME)"
+	$(call colorecho, "\n- DONE! Check $(DRUPAL_URL) ...\n")
 
 define colorecho
     @tput -T xterm setaf 3

diff --git a/examples/ghost/Makefile b/examples/ghost/Makefile
@@ -1,6 +1,8 @@
 .PHONY: down help up
 .DEFAULT_GOAL := help
 
+GHOST_URL := http://ghost.docker.sh
+
 down: ## Tear down example Ghost application
 	@docker-compose down -v
 
@@ -12,7 +14,7 @@ help: ## Print this help
 up: ## Launch example Ghost application
 	$(call colorecho, "\nStart Ghost example application...")
 	@docker-compose up -d
-	$(call colorecho, "\n- DONE! Check http://ghost.docker.sh ...\n")
+	$(call colorecho, "\n- DONE! Check $(GHOST_URL) ...\n")
 
 define colorecho
     @tput -T xterm setaf 3

diff --git a/examples/symfony/Makefile b/examples/symfony/Makefile
@@ -1,6 +1,8 @@
 .PHONY: down help up
 .DEFAULT_GOAL := help
 
+SF_URL := http://symfony.docker.sh
+
 app:
 	$(call colorecho, "\nCreate Symfony project to app folder")
 	@docker run --rm --interactive --tty --volume $(shell pwd):/app composer create-project symfony/website-skeleton app
@@ -17,7 +19,7 @@ help: ## Print this help
 up: app ## Launch example Symfony application
 	$(call colorecho, "\nStart Symfony example application...")
 	@docker-compose up -d
-	$(call colorecho, "\n- DONE! Check http://symfony.docker.sh ...\n")
+	$(call colorecho, "\n- DONE! Check $(SF_URL) ...\n")
 
 define colorecho
     @tput -T xterm setaf 3

diff --git a/examples/wordpress/Makefile b/examples/wordpress/Makefile
@@ -1,6 +1,8 @@
 .PHONY: down help up
 .DEFAULT_GOAL := help
 
+WP_URL := http://wordpress.docker.sh
+
 down: ## Tear down example Wordpress site
 	@docker-compose down -v
 
@@ -12,7 +14,7 @@ help: ## Print this help
 up: ## Launch example Wordpress site
 	$(call colorecho, "\nStart Wordpress example site...")
 	@docker-compose up -d
-	$(call colorecho, "\n- DONE! Check http://wordpress.docker.sh ...\n")
+	$(call colorecho, "\n- DONE! Check $(WP_URL) ...\n")
 
 define colorecho
     @tput -T xterm setaf 3