Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-90092 Log exceptions when closing BaseAllocator. #70

Merged
merged 2 commits into from
May 1, 2024

Conversation

lriggs
Copy link

@lriggs lriggs commented Apr 23, 2024

Changes to log the allocation details of the leaked memory
via Allocator.toVerboseString when the allocator is closed. The detailed
information is available only when --Darrow.memory.debug.allocator=true
is set at the time of starting the dremio executor process.

Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

Copy link

@selvaganesang selvaganesang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the description as below.
Changes to log the allocation details of the leaked memory
via Allocator.toVerboseString when the allocator is closed. The detailed
information is available only when --Darrow.memory.debug.allocator=true
is set at the time of starting the dremio executor process.

@lriggs lriggs merged commit 0721d67 into dremio:dremio_25.0_15.0.1 May 1, 2024
13 of 17 checks passed
lriggs added a commit to lriggs/arrow that referenced this pull request Sep 6, 2024
* Added logging for exceptions

* DX-90092 Log exceptions when closing BaseAllocator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants