Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI against Rails 8.0 #938

Merged
merged 1 commit into from
Jan 5, 2025
Merged

CI against Rails 8.0 #938

merged 1 commit into from
Jan 5, 2025

Conversation

y-yagi
Copy link
Collaborator

@y-yagi y-yagi commented Nov 12, 2024

Description

Rails 8.0 has been released. I would like to confirm whether draper works well with it.

@y-yagi y-yagi force-pushed the ci_against_rails80 branch from 10dc678 to 6a10c9a Compare November 12, 2024 07:38
@y-yagi
Copy link
Collaborator Author

y-yagi commented Nov 12, 2024

Need to fix rspec-activerecord-expectations first.
https://github.com/drapergem/draper/actions/runs/11792755485/job/32846939180?pr=938#step:4:105

@y-yagi y-yagi closed this Dec 15, 2024
@y-yagi y-yagi reopened this Dec 15, 2024
@y-yagi
Copy link
Collaborator Author

y-yagi commented Dec 15, 2024

minitest-rails doesn't support Rails 8.0 yet. Ref: minitest/minitest-rails#258

@y-yagi y-yagi closed this Jan 3, 2025
@y-yagi y-yagi reopened this Jan 3, 2025
@y-yagi
Copy link
Collaborator Author

y-yagi commented Jan 4, 2025

Finally, the tests are passed. It's time to go.

@y-yagi y-yagi marked this pull request as ready for review January 4, 2025 23:08
@y-yagi y-yagi requested a review from Alexander-Senko January 4, 2025 23:08
@y-yagi y-yagi merged commit a155391 into drapergem:master Jan 5, 2025
27 of 33 checks passed
@y-yagi y-yagi deleted the ci_against_rails80 branch January 5, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants