Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize service v2 log print #2922

Merged
merged 1 commit into from
Dec 6, 2023
Merged

feat: optimize service v2 log print #2922

merged 1 commit into from
Dec 6, 2023

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Dec 6, 2023

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Dec 6, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Dec 6, 2023
@gaius-qi gaius-qi self-assigned this Dec 6, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner December 6, 2023 07:53
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #2922 (2554a8a) into main (cfcfbc3) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2922      +/-   ##
==========================================
- Coverage   51.03%   51.00%   -0.04%     
==========================================
  Files         161      161              
  Lines       21786    21786              
==========================================
- Hits        11119    11111       -8     
- Misses      10009    10014       +5     
- Partials      658      661       +3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.00% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/service/service_v2.go 84.48% <0.00%> (-0.37%) ⬇️

... and 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 81cfc72 into main Dec 6, 2023
21 checks passed
@gaius-qi gaius-qi deleted the feature/log branch December 6, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants