Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove handleSyncPiecesFailedRequest when sync piece failed #2906

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request scheduler labels Nov 29, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Nov 29, 2023
@gaius-qi gaius-qi self-assigned this Nov 29, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner November 29, 2023 13:08
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #2906 (77e5430) into main (0431b32) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2906   +/-   ##
=======================================
  Coverage   51.04%   51.05%           
=======================================
  Files         161      161           
  Lines       21781    21778    -3     
=======================================
  Hits        11118    11118           
+ Misses      10005    10002    -3     
  Partials      658      658           
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.05% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/service/service_v2.go 85.47% <ø> (+0.31%) ⬆️

... and 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 64e9c0f into main Nov 30, 2023
@gaius-qi gaius-qi deleted the feature/handle branch November 30, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant