Skip to content

Commit 756906c

Browse files
Aleksy Lisowskipiotrczarnas
Aleksy Lisowski
authored andcommitted
Merged PR 2645: 11752 sending checkTypes to request status on TableColumn page correctly
sending checkTypes to request status on TableColumn page correctly
2 parents 1c79615 + abce063 commit 756906c

File tree

1 file changed

+37
-20
lines changed

1 file changed

+37
-20
lines changed

dqops/src/main/frontend/src/pages/TableColumnsView/TableColumns.tsx

+37-20
Original file line numberDiff line numberDiff line change
@@ -20,29 +20,33 @@ import { ITableColumnsProps, MyData, spec } from './TableColumnsConstans';
2020
import TableColumnsHeader from './TableColumnsHeader';
2121
import { renderValue } from './TableColumnsUtils';
2222

23-
const getSeverityLevel = (severity: CheckCurrentDataQualityStatusModelCurrentSeverityEnum | undefined) => {
23+
const getSeverityLevel = (
24+
severity: CheckCurrentDataQualityStatusModelCurrentSeverityEnum | undefined
25+
) => {
2426
switch (severity) {
25-
case 'execution_error':
27+
case 'execution_error':
2628
return 4;
27-
case 'fatal' :
29+
case 'fatal':
2830
return 3;
29-
case 'error':
31+
case 'error':
3032
return 2;
31-
case 'warning':
33+
case 'warning':
3234
return 1;
3335
case 'valid':
34-
return 0;
36+
return 0;
3537
}
3638
return 4;
37-
}
39+
};
3840

39-
const rewriteDimensions = (columnStatus : { [key: string]: ColumnCurrentDataQualityStatusModel }) => {
40-
const obj : any = {};
41+
const rewriteDimensions = (columnStatus: {
42+
[key: string]: ColumnCurrentDataQualityStatusModel;
43+
}) => {
44+
const obj: any = {};
4145
Object.entries(columnStatus).forEach(([key, value]) => {
4246
obj[key] = value.dimensions;
43-
});
47+
});
4448
return obj;
45-
}
49+
};
4650

4751
const prepareLabel = (label: string | undefined) => {
4852
if (!label) return;
@@ -67,16 +71,18 @@ const TableColumns = ({
6771
onChangeSelectedColumns,
6872
refreshListFunc
6973
}: ITableColumnsProps) => {
70-
const {checkTypes} : {checkTypes: CheckTypes} = useDecodedParams()
74+
const { checkTypes }: { checkTypes: CheckTypes } = useDecodedParams();
7175
const [isOpen, setIsOpen] = useState(false);
7276
const [selectedColumn, setSelectedColumn] = useState<ColumnStatisticsModel>();
7377
const [sortedArray, setSortedArray] = useState<MyData[]>();
7478
const [objectStates, setObjectStates] = useState<{ [key: string]: boolean }>(
7579
{}
7680
);
7781
const [shouldResetCheckboxes, setShouldResetCheckboxes] = useState(false);
78-
const [status, setStatus] = useState<{ [key: string]: ColumnCurrentDataQualityStatusModel }>({})
79-
const [columns, setColumns] = useState<ColumnListModel[]>([])
82+
const [status, setStatus] = useState<{
83+
[key: string]: ColumnCurrentDataQualityStatusModel;
84+
}>({});
85+
const [columns, setColumns] = useState<ColumnListModel[]>([]);
8086

8187
const handleButtonClick = (name: string) => {
8288
setObjectStates((prevStates) => ({
@@ -275,15 +281,26 @@ const TableColumns = ({
275281
</div>
276282
);
277283
}
278-
const handleSorting = (data: MyData[]) => {
279-
const arr = [...data]
284+
const handleSorting = (data: MyData[]) => {
285+
const arr = [...data];
280286
setSortedArray(arr);
281-
}
287+
};
282288

283289
useEffect(() => {
284-
CheckResultApi.getTableDataQualityStatus(connectionName, schemaName, tableName, undefined, undefined, checkTypes === CheckTypes.PROFILING ? true : undefined).then((res) => setStatus(res.data.columns ?? {}));
285-
ColumnApiClient.getColumns(connectionName, schemaName, tableName).then((res) => setColumns(res.data))
286-
}, [connectionName, schemaName, tableName]);
290+
CheckResultApi.getTableDataQualityStatus(
291+
connectionName,
292+
schemaName,
293+
tableName,
294+
undefined,
295+
undefined,
296+
checkTypes === CheckTypes.PROFILING ? true : undefined,
297+
checkTypes === CheckTypes.MONITORING ? true : undefined,
298+
checkTypes === CheckTypes.PARTITIONED ? true : undefined
299+
).then((res) => setStatus(res.data.columns ?? {}));
300+
ColumnApiClient.getColumns(connectionName, schemaName, tableName).then(
301+
(res) => setColumns(res.data)
302+
);
303+
}, [checkTypes, connectionName, schemaName, tableName]);
287304

288305
return (
289306
<div className="p-4 relative">

0 commit comments

Comments
 (0)