Skip to content

Commit 68a6a88

Browse files
Patryk Jatczakpiotrczarnas
Patryk Jatczak
authored and
piotrczarnas
committed
Merged PR 2661: unit tests fixed - some sensors still need work
Related work items: #11865
2 parents 31ea9d2 + 8938597 commit 68a6a88

File tree

102 files changed

+1234
-2137
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

102 files changed

+1234
-2137
lines changed

‎dqops/src/test/java/com/dqops/sensors/bigquery/column/acceptedvalues/ColumnAcceptedValuesTextFoundInSetPercentSensorParametersSpecBigQueryTests.java

+9-17
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ void renderSensor_whenProfilingNoTimeSeriesNoDataStreamNoValuesList_thenRendersC
150150
String renderedTemplate = JinjaTemplateRenderServiceObjectMother.renderBuiltInTemplate(runParameters);
151151
String target_query = """
152152
SELECT
153-
0.0 AS actual_value
153+
MAX(0.0) AS actual_value
154154
FROM `%s`.`%s`.`%s` AS analyzed_table
155155
WHERE %s""";
156156

@@ -220,13 +220,9 @@ WHEN COUNT(%s) = 0 THEN 100.0
220220
ELSE 0
221221
END
222222
) / COUNT(%s)
223-
END AS actual_value,
224-
DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
225-
TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
223+
END AS actual_value
226224
FROM `%s`.`%s`.`%s` AS analyzed_table
227-
WHERE %s
228-
GROUP BY time_period, time_period_utc
229-
ORDER BY time_period, time_period_utc""";
225+
WHERE %s""";
230226

231227
Assertions.assertEquals(String.format(target_query,
232228
this.getTableColumnName(runParameters),
@@ -338,13 +334,11 @@ WHEN COUNT(%s) = 0 THEN 100.0
338334
END
339335
) / COUNT(%s)
340336
END AS actual_value,
341-
analyzed_table.`length_int` AS grouping_level_1,
342-
DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
343-
TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
337+
analyzed_table.`length_int` AS grouping_level_1
344338
FROM `%s`.`%s`.`%s` AS analyzed_table
345339
WHERE %s
346-
GROUP BY grouping_level_1, time_period, time_period_utc
347-
ORDER BY grouping_level_1, time_period, time_period_utc""";
340+
GROUP BY grouping_level_1
341+
ORDER BY grouping_level_1""";
348342

349343
Assertions.assertEquals(String.format(target_query,
350344
this.getTableColumnName(runParameters),
@@ -474,13 +468,11 @@ WHEN COUNT(%s) = 0 THEN 100.0
474468
END AS actual_value,
475469
analyzed_table.`strings_with_numbers` AS grouping_level_1,
476470
analyzed_table.`mix_of_values` AS grouping_level_2,
477-
analyzed_table.`length_int` AS grouping_level_3,
478-
DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
479-
TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
471+
analyzed_table.`length_int` AS grouping_level_3
480472
FROM `%s`.`%s`.`%s` AS analyzed_table
481473
WHERE %s
482-
GROUP BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc
483-
ORDER BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc""";
474+
GROUP BY grouping_level_1, grouping_level_2, grouping_level_3
475+
ORDER BY grouping_level_1, grouping_level_2, grouping_level_3""";
484476

485477
Assertions.assertEquals(String.format(target_query,
486478
this.getTableColumnName(runParameters),

‎dqops/src/test/java/com/dqops/sensors/bigquery/column/acceptedvalues/ColumnNumericExpectedNumbersInUseCountSensorParametersSpecBigQueryTests.java

+8-16
Original file line numberDiff line numberDiff line change
@@ -212,13 +212,9 @@ void renderSensor_whenMonitoringDefaultTimeSeriesNoDataStream_thenRendersCorrect
212212
ELSE NULL
213213
END
214214
) AS actual_value,
215-
MAX(3) AS expected_value,
216-
DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
217-
TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
215+
MAX(3) AS expected_value
218216
FROM `%s`.`%s`.`%s` AS analyzed_table
219-
WHERE %s
220-
GROUP BY time_period, time_period_utc
221-
ORDER BY time_period, time_period_utc""";
217+
WHERE %s""";
222218

223219
Assertions.assertEquals(String.format(target_query,
224220
this.getTableColumnName(runParameters),
@@ -321,13 +317,11 @@ void renderSensor_whenMonitoringDefaultTimeSeriesOneDataStream_thenRendersCorrec
321317
END
322318
) AS actual_value,
323319
MAX(3) AS expected_value,
324-
analyzed_table.`length_string` AS grouping_level_1,
325-
DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
326-
TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
320+
analyzed_table.`length_string` AS grouping_level_1
327321
FROM `%s`.`%s`.`%s` AS analyzed_table
328322
WHERE %s
329-
GROUP BY grouping_level_1, time_period, time_period_utc
330-
ORDER BY grouping_level_1, time_period, time_period_utc""";
323+
GROUP BY grouping_level_1
324+
ORDER BY grouping_level_1""";
331325

332326
Assertions.assertEquals(String.format(target_query,
333327
this.getTableColumnName(runParameters),
@@ -448,13 +442,11 @@ void renderSensor_whenMonitoringDefaultTimeSeriesThreeDataStream_thenRendersCorr
448442
MAX(3) AS expected_value,
449443
analyzed_table.`strings_with_numbers` AS grouping_level_1,
450444
analyzed_table.`mix_of_values` AS grouping_level_2,
451-
analyzed_table.`length_string` AS grouping_level_3,
452-
DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
453-
TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
445+
analyzed_table.`length_string` AS grouping_level_3
454446
FROM `%s`.`%s`.`%s` AS analyzed_table
455447
WHERE %s
456-
GROUP BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc
457-
ORDER BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc""";
448+
GROUP BY grouping_level_1, grouping_level_2, grouping_level_3
449+
ORDER BY grouping_level_1, grouping_level_2, grouping_level_3""";
458450

459451
Assertions.assertEquals(String.format(target_query,
460452
this.getTableColumnName(runParameters),

‎dqops/src/test/java/com/dqops/sensors/bigquery/column/acceptedvalues/ColumnNumericNumberFoundInSetPercentSensorParametersSpecBigQueryTests.java

+9-17
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ void renderSensor_whenProfilingNoTimeSeriesNoDataStreamNoValuesList_thenRendersC
149149
String renderedTemplate = JinjaTemplateRenderServiceObjectMother.renderBuiltInTemplate(runParameters);
150150
String target_query = """
151151
SELECT
152-
0.0 AS actual_value
152+
MAX(0.0) AS actual_value
153153
FROM `%s`.`%s`.`%s` AS analyzed_table
154154
WHERE %s""";
155155

@@ -219,13 +219,9 @@ WHEN COUNT(%s) = 0 THEN 100.0
219219
ELSE 0
220220
END
221221
) / COUNT(%s)
222-
END AS actual_value,
223-
DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
224-
TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
222+
END AS actual_value
225223
FROM `%s`.`%s`.`%s` AS analyzed_table
226-
WHERE %s
227-
GROUP BY time_period, time_period_utc
228-
ORDER BY time_period, time_period_utc""";
224+
WHERE %s""";
229225

230226
Assertions.assertEquals(String.format(target_query,
231227
this.getTableColumnName(runParameters),
@@ -337,13 +333,11 @@ WHEN COUNT(%s) = 0 THEN 100.0
337333
END
338334
) / COUNT(%s)
339335
END AS actual_value,
340-
analyzed_table.`length_string` AS grouping_level_1,
341-
DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
342-
TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
336+
analyzed_table.`length_string` AS grouping_level_1
343337
FROM `%s`.`%s`.`%s` AS analyzed_table
344338
WHERE %s
345-
GROUP BY grouping_level_1, time_period, time_period_utc
346-
ORDER BY grouping_level_1, time_period, time_period_utc""";
339+
GROUP BY grouping_level_1
340+
ORDER BY grouping_level_1""";
347341

348342
Assertions.assertEquals(String.format(target_query,
349343
this.getTableColumnName(runParameters),
@@ -473,13 +467,11 @@ WHEN COUNT(%s) = 0 THEN 100.0
473467
END AS actual_value,
474468
analyzed_table.`strings_with_numbers` AS grouping_level_1,
475469
analyzed_table.`mix_of_values` AS grouping_level_2,
476-
analyzed_table.`length_string` AS grouping_level_3,
477-
DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
478-
TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
470+
analyzed_table.`length_string` AS grouping_level_3
479471
FROM `%s`.`%s`.`%s` AS analyzed_table
480472
WHERE %s
481-
GROUP BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc
482-
ORDER BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc""";
473+
GROUP BY grouping_level_1, grouping_level_2, grouping_level_3
474+
ORDER BY grouping_level_1, grouping_level_2, grouping_level_3""";
483475

484476
Assertions.assertEquals(String.format(target_query,
485477
this.getTableColumnName(runParameters),

‎dqops/src/test/java/com/dqops/sensors/bigquery/column/acceptedvalues/ColumnStringsExpectedTextValuesInUseCountSensorParametersSpecBigQueryTests.java

+8-16
Original file line numberDiff line numberDiff line change
@@ -213,13 +213,9 @@ void renderSensor_whenMonitoringDefaultTimeSeriesNoDataStream_thenRendersCorrect
213213
ELSE NULL
214214
END
215215
) AS actual_value,
216-
MAX(3) AS expected_value,
217-
DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
218-
TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
216+
MAX(3) AS expected_value
219217
FROM `%s`.`%s`.`%s` AS analyzed_table
220-
WHERE %s
221-
GROUP BY time_period, time_period_utc
222-
ORDER BY time_period, time_period_utc""";
218+
WHERE %s""";
223219

224220
Assertions.assertEquals(String.format(target_query,
225221
this.getTableColumnName(runParameters),
@@ -322,13 +318,11 @@ void renderSensor_whenMonitoringDefaultTimeSeriesOneDataStream_thenRendersCorrec
322318
END
323319
) AS actual_value,
324320
MAX(3) AS expected_value,
325-
analyzed_table.`length_int` AS grouping_level_1,
326-
DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
327-
TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
321+
analyzed_table.`length_int` AS grouping_level_1
328322
FROM `%s`.`%s`.`%s` AS analyzed_table
329323
WHERE %s
330-
GROUP BY grouping_level_1, time_period, time_period_utc
331-
ORDER BY grouping_level_1, time_period, time_period_utc""";
324+
GROUP BY grouping_level_1
325+
ORDER BY grouping_level_1""";
332326

333327
Assertions.assertEquals(String.format(target_query,
334328
this.getTableColumnName(runParameters),
@@ -449,13 +443,11 @@ void renderSensor_whenMonitoringDefaultTimeSeriesThreeDataStream_thenRendersCorr
449443
MAX(3) AS expected_value,
450444
analyzed_table.`strings_with_numbers` AS grouping_level_1,
451445
analyzed_table.`mix_of_values` AS grouping_level_2,
452-
analyzed_table.`length_int` AS grouping_level_3,
453-
DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH) AS time_period,
454-
TIMESTAMP(DATE_TRUNC(CAST(CURRENT_TIMESTAMP() AS DATE), MONTH)) AS time_period_utc
446+
analyzed_table.`length_int` AS grouping_level_3
455447
FROM `%s`.`%s`.`%s` AS analyzed_table
456448
WHERE %s
457-
GROUP BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc
458-
ORDER BY grouping_level_1, grouping_level_2, grouping_level_3, time_period, time_period_utc""";
449+
GROUP BY grouping_level_1, grouping_level_2, grouping_level_3
450+
ORDER BY grouping_level_1, grouping_level_2, grouping_level_3""";
459451

460452
Assertions.assertEquals(String.format(target_query,
461453
this.getTableColumnName(runParameters),

0 commit comments

Comments
 (0)