Skip to content

Commit 5b636fb

Browse files
Aleksy Lisowskipiotrczarnas
Aleksy Lisowski
authored andcommitted
Merged PR 2611: 11583 added border to quality dimensions & extended tooltips
added border to quality dimensions & extended tooltips
2 parents d906ebd + 571734c commit 5b636fb

File tree

2 files changed

+38
-12
lines changed

2 files changed

+38
-12
lines changed

dqops/src/main/frontend/src/components/Connection/TableView/TableQualityStatus/TableQualityStatusUtils.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ import { TFirstLevelCheck, severityMap } from './TableQualityStatusConstans';
88

99
export const getColor = (
1010
status:
11-
| CheckCurrentDataQualityStatusModelCurrentSeverityEnum
12-
| DimensionCurrentDataQualityStatusModelCurrentSeverityEnum
11+
| CheckCurrentDataQualityStatusModelCurrentSeverityEnum
12+
| DimensionCurrentDataQualityStatusModelCurrentSeverityEnum
1313
| null
1414
| undefined
1515
) => {
@@ -18,13 +18,13 @@ export const getColor = (
1818
case CheckCurrentDataQualityStatusModelCurrentSeverityEnum.execution_error:
1919
return 'bg-gray-150';
2020
case CheckCurrentDataQualityStatusModelCurrentSeverityEnum.fatal:
21-
return 'bg-red-200';
21+
return 'bg-red-300';
2222
case CheckCurrentDataQualityStatusModelCurrentSeverityEnum.error:
23-
return 'bg-orange-200';
23+
return 'bg-orange-300';
2424
case CheckCurrentDataQualityStatusModelCurrentSeverityEnum.warning:
25-
return 'bg-yellow-200';
25+
return 'bg-yellow-300';
2626
case CheckCurrentDataQualityStatusModelCurrentSeverityEnum.valid:
27-
return 'bg-green-200';
27+
return 'bg-green-300';
2828
default:
2929
return '';
3030
}

dqops/src/main/frontend/src/pages/TableColumnsView/TableColumnsBody.tsx

+32-6
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,30 @@ export default function TableColumnsBody({
159159
<div className="w-49">Quality Dimension:</div>
160160
<div>{data?.dimension}</div>
161161
</div>
162+
<div className="flex gap-x-2">
163+
<div className="w-49">Executed checks:</div>
164+
<div>{data?.executed_checks}</div>
165+
</div>
166+
<div className="flex gap-x-2">
167+
<div className="w-49">Valid results:</div>
168+
<div>{data?.valid_results}</div>
169+
</div>
170+
<div className="flex gap-x-2">
171+
<div className="w-49">Warnings:</div>
172+
<div>{data?.warnings}</div>
173+
</div>
174+
<div className="flex gap-x-2">
175+
<div className="w-49">Errors:</div>
176+
<div>{data?.errors}</div>
177+
</div>
178+
<div className="flex gap-x-2">
179+
<div className="w-49">Fatals:</div>
180+
<div>{data?.fatals}</div>
181+
</div>
182+
<div className="flex gap-x-2">
183+
<div className="w-49">Data quality KPI:</div>
184+
<div>{data?.data_quality_kpi}</div>
185+
</div>
162186
</div>
163187
);
164188
}
@@ -272,11 +296,13 @@ export default function TableColumnsBody({
272296
const severityColor = getColor(currentSeverity as any);
273297
const hasNoSeverity = severityColor.length === 0;
274298

275-
const dimensionsClassNames = clsx('w-3 h-3', {
276-
'bg-gray-150': hasNoSeverity && lastCheckExecutedAt,
277-
[severityColor]: !hasNoSeverity,
278-
'border border-gray-150': hasNoSeverity
279-
});
299+
const dimensionsClassNames = clsx(
300+
'w-3 h-3 border border-gray-150',
301+
{
302+
'bg-gray-150': hasNoSeverity && lastCheckExecutedAt,
303+
[severityColor]: !hasNoSeverity
304+
}
305+
);
280306
return (
281307
<Tooltip
282308
key={`Dimensionindex${dimType}`}
@@ -304,7 +330,7 @@ export default function TableColumnsBody({
304330
>
305331
<div
306332
className={clsx(
307-
'w-3 h-3',
333+
'w-3 h-3 border border-gray-150',
308334
getColor(
309335
column.dimentions?.[dimensionKey as any]
310336
?.current_severity as

0 commit comments

Comments
 (0)