Add CoreWCF Services Support #5473
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afifi-ins
force-pushed
the
AddCoreWcfServicesatest
branch
from
4e0e6d8 to
6b217de
Compare
afifi-ins
force-pushed
the
AddCoreWcfServicesatest
branch
from
4049c03 to
3f6dad8
Compare
afifi-ins
force-pushed
the
AddCoreWcfServicesatest
branch
4 times, most recently
from
5787e3c to
7eef23d
Compare
afifi-ins
force-pushed
the
AddCoreWcfServicesatest
branch
from
c4daf36 to
dd2e1d2
Compare
afifi-ins
force-pushed
the
AddCoreWcfServicesatest
branch
from
0fc1297 to
6d4fa39
Compare
afifi-ins
force-pushed
the
AddCoreWcfServicesatest
branch
from
ebc64f8 to
bae0e73
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
afifi-ins
force-pushed
the
AddCoreWcfServicesatest
branch
from
f092ed7 to
274dc78
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
HongGit
reviewed
Sep 24, 2024
NuGet.config
Outdated
| <configuration> | ||
| <packageSources> | ||
| <clear /> | ||
| <add key="dotnet-eng" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" /> | ||
| <add key="dotnet-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" /> | ||
| <add key="dotnet-public" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json" /> | ||
| <add key="nuget" value="https://api.nuget.org/v3/index.json" /> |
There was a problem hiding this comment.
If I remember this correctly, this is not allowed, We should achieve this through dotnet-public.
NuGet.config
Outdated
| <configuration> | ||
| <packageSources> | ||
| <clear /> | ||
| <add key="dotnet-eng" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" /> | ||
| <add key="dotnet-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" /> | ||
| <add key="dotnet-public" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json" /> | ||
| <add key="nuget" value="https://api.nuget.org/v3/index.json" /> | ||
| <add key="CoreWCF_Dev" value="https://pkgs.dev.azure.com/dotnet/CoreWCF/_packaging/CoreWCF/nuget/v3/index.json" /> |
There was a problem hiding this comment.
Couldn't we just use the latest CoreWCF package for this? Or perhaps this should be added to the dotnet-public?
HongGit
reviewed
Sep 24, 2024
eng/SendToHelix.proj
Outdated
|
|
||
| <Target Name="InstallDotNet"> | ||
| <ItemGroup> | ||
| <AdditionalDotNetPackage Include="8.0.5"> |
There was a problem hiding this comment.
This seems to be downgrade; can we use what is available provided by arcade?
afifi-ins
force-pushed
the
AddCoreWcfServicesatest
branch
from
d2b48bc to
5301ab2
Compare
afifi-ins
force-pushed
the
AddCoreWcfServicesatest
branch
from
3370a51 to
a5b1c1c
Compare
|
/azp run |
|
Commenter does not have sufficient privileges for PR 5473 in repo dotnet/wcf |
|
/azp run |
|
Pull request contains merge conflicts. |
afifi-ins
force-pushed
the
AddCoreWcfServicesatest
branch
2 times, most recently
from
f9dc9da to
d1ec63f
Compare
afifi-ins
force-pushed
the
AddCoreWcfServicesatest
branch
from
87edf75 to
41f3ec1
Compare
afifi-ins
force-pushed
the
AddCoreWcfServicesatest
branch
3 times, most recently
from
0f5c2f0 to
d11e770
Compare
afifi-ins
force-pushed
the
AddCoreWcfServicesatest
branch
from
529bd04 to
af14463
Compare
mconnew
reviewed
Apr 16, 2025
src/System.Private.ServiceModel/tools/SelfHostedCoreWcfService/Properties/launchSettings.json
Outdated
Show resolved
Hide resolved
|
@afifi-ins, just the one comment about the launchSettings.json file, and can you rebase this PR and squash your commits down to a single commit? |
…ice for test hosts. Refactor project for CoreWCF compatibility and updates. This commit includes significant updates to transition the codebase from traditional WCF to CoreWCF, enhancing compatibility with .NET Core. Key changes include: - Updates to Azure pipeline configurations to support new environment variables and MacOS build conditions. - Introduction of new methods in `ConditionalTestDetectors.cs` for checking CoreWCF service status. - Improvements in error handling within `ServiceUtilHelper.cs` for HTTP requests. - Fixes to endpoint address formatting in `Endpoints.cs`. - Implementation of digest authentication in new `DigestAuthentication` classes. - Enhancements to certificate handling in `CertificateGenerator` and `CertificateManager`. - Updates to various test classes to improve reliability when running with CoreWCF. - Overall project structure and dependency updates to reflect the new architecture using CoreWCF and .NET Core compatibility.
afifi-ins
force-pushed
the
AddCoreWcfServicesatest
branch
from
daf8ca1 to
6914632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase latest branch