Fix a couple of Razor project issues #11645
Open
+96
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that CloseDocument can easily fail resulting in IsDocumentOpen to report true for documents that are not actually open. This is because the _openDocumentSet is only updated after updating the project with a SourceText or TextLoader. For example, if the project has already been removed, CloseDocument wouldn't update the _openDocumentSet. This change updates _openDocumentSet before updating the document text, which should by more correct.
Retrieving TagHelperDescriptors from OOP is a two step process. 1. Call into OOP to get the checksum delta for tag helpers that are different from the last request. 2. If there are any checksums that aren't cached on the client-side, call into OOP to fetch them. Unfortunately, the OutOfProcTagHelperResolver would always add any fetched tag helpers to the end of the array, effectively reordering them. Once ProjectState is updated with a ProjectWorkspaceState created with this set of tag helpers, they wouldn't equal the same tag helpers assigned by subsequent calls to OOP because SequenceEquals(...) wouldn't return true.
davidwengier
approved these changes
Mar 19, 2025
ryzngard
approved these changes
Mar 19, 2025
...or/src/Microsoft.VisualStudio.LanguageServices.Razor/Discovery/OutOfProcTagHelperResolver.cs
Show resolved
Hide resolved
...or/src/Microsoft.VisualStudio.LanguageServices.Razor/Discovery/OutOfProcTagHelperResolver.cs
Show resolved
Hide resolved
With the current implementation, this should never happen. However, if something changes and *does* start happening, we'll log a warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was debugging through
ProjectSnapshotManagerand noticed a couple of issues:ProjectSnapshotManager's open documents on solution close.ProjectWorkspaceStateis updated for a project with exactly the same tag helpers in a different order. This results inSequenceEquals(...)returning false when comparing old and newProjectWorkspaceStateand all of the documents being invalidated.CI Build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2668365&view=results
Test Insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/621080