chore: Add InternalsVisibleTo
attribute for benchmark
#9652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included in this PR
Add
InternalsVisibleTo
attribute for following assembly names.Docfx.Benchmarks
LINQPadQuery
Background
I want to write benchmark & test code that use docfx internal types.
Currently I'm using
IgnoresAccessChecksToGenerator
to ignore .NET access checks.But there are some limitations. (e.g. it can't using from LINQPad)
So I want to add
InternalsVisibleTo
attributes for specific assembly names to docfx DLLs..NET Accessibility Levels is not security features. And it can be ignorable by several ways. (e.g. By using .NET 8 UnsafeAccessorAttribute)
I don't think there is a problem with the addition of the InternalsVisibleTo attribute to external assembly names.