Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify regex settings #10539

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Feb 13, 2025

This PR contains following changes.

  1. Replace regex that use static expression to GeneratedRegexAttribute. (that are reported as SYSLIB1045 messages.)
  2. Replace regex that use dynamic expression to use Regex's static method to use cached regex.
    (Note: default Regex.CacheSize is 15))
  3. Suppress SYSLIB1045 messages from test projects.
  4. Revert MustacheTemplateRenderer's regex to Regex instance.
    Because it's not supported by source generator.

@yufeih yufeih merged commit 29dbd29 into dotnet:main Feb 18, 2025
10 checks passed
filzrev added a commit to filzrev/docfx that referenced this pull request Feb 18, 2025
* chore: modify regex settings

* chore: fix ci error of plantuml test
filzrev added a commit to filzrev/docfx that referenced this pull request Feb 18, 2025
* chore: modify regex settings

* chore: fix ci error of plantuml test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants