perf: Optimize pdf generation performance by reducing file I/O #10461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to optimize PDF generation performance.
On current implementation.
1 .
PrintHeaderFooterCore
method is called every page numbers. And it access physical every times.2. When header/footer is specified as string. It process try-catch operation every times.
What's changed in this PR
InvalidPathChars
checks to detectpdfHeaderTemplate
/pdfFooterTemplate
is HTML content or not.headerFooterTemplateCache
to reduce file I/O.headerFooterCache
toheaderFooterPageCache