Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Explicitly set ‘IsTestProject‘ property to false for non-test project #10298

Merged
merged 2 commits into from
Oct 19, 2024
Merged

chore: Explicitly set ‘IsTestProject‘ property to false for non-test project #10298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89c2446
chore: Disable test for non-test project
filzrev Oct 19, 2024
cd3987b
chore: remove .NET 6 target from Snapshot.Tests
filzrev Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/Docfx.Tests.Common/Docfx.Tests.Common.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<IsTestProject>false</IsTestProject>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\..\src\Docfx.Common\Docfx.Common.csproj" />
</ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions test/docfx.Snapshot.Tests/SamplesTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ private class SamplesFactAttribute : FactAttribute
{
public SamplesFactAttribute()
{
// When target framework is changed.
// It need to modify TargetFrameworks property of `docfx.Snapshot.Tests.csproj`
#if !NET8_0
Skip = "Skip by target framework";
#endif
Expand Down
4 changes: 4 additions & 0 deletions test/docfx.Snapshot.Tests/docfx.Snapshot.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net8.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Playwright" />
<PackageReference Include="Verify.DiffPlex" />
Expand Down