chore: Explicitly set ‘IsTestProject‘ property to false for non-test project
#10298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filzrev
force-pushed
the
chore-modify-istestproject-setting
branch
from
d07395b to
cd3987b
Compare
filzrev
changed the title
fa;se for non-test projectfalse for non-test project
yufeih
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change
Docfx.Tests.Commonproject'sIsTestProjectproperty tofalse.Because it's shared library project and not contais tests.
It's required to exclude projects from test execution.
e.g. https://github.com/dotnet/docfx/runs/31762712785#r60
Additionally
docfx.Snapshot.Testsproject for.NET 6have no runnable tests.So I've override
TargetFrameworksproperty with following reasons.150MB)