chore: remove redundant private set (#10343)

dotnet · Nov 4, 2024 · 334ec01 · 334ec01
1 parent ffd1fb7
commit 334ec01
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/src/Docfx.DataContracts.Common/ExternalReferences/ExternalReferencePackageCollection.cs b/src/Docfx.DataContracts.Common/ExternalReferences/ExternalReferencePackageCollection.cs
@@ -24,7 +24,7 @@ public ExternalReferencePackageCollection(IEnumerable<string> packageFiles, int
                    select reader).ToImmutableList();
     }
 
-    public ImmutableList<ExternalReferencePackageReader> Readers { get; private set; }
+    public ImmutableList<ExternalReferencePackageReader> Readers { get; }
 
     public bool TryGetReference(string uid, out ReferenceViewModel vm)
     {

diff --git a/src/Docfx.Dotnet/Parsers/XmlComment.cs b/src/Docfx.Dotnet/Parsers/XmlComment.cs
@@ -42,9 +42,9 @@ internal class XmlComment
 
     public List<string> Examples { get; private set; }
 
-    public Dictionary<string, string> Parameters { get; private set; }
+    public Dictionary<string, string> Parameters { get; }
 
-    public Dictionary<string, string> TypeParameters { get; private set; }
+    public Dictionary<string, string> TypeParameters { get; }
 
     private XmlComment(string xml, XmlCommentParserContext context)
     {

diff --git a/src/Docfx.Plugins/FileModel.cs b/src/Docfx.Plugins/FileModel.cs
@@ -35,7 +35,7 @@ public FileModel(FileAndType ft, object content, FileAndType original, string ke
 
     public FileAndType FileAndType { get; private set; }
 
-    public FileAndType OriginalFileAndType { get; private set; }
+    public FileAndType OriginalFileAndType { get; }
 
     public object Content { get; set; }
 

diff --git a/src/Docfx.YamlSerialization/YamlDeserializer.cs b/src/Docfx.YamlSerialization/YamlDeserializer.cs
@@ -39,8 +39,8 @@ public sealed class YamlDeserializer
     private readonly IValueDeserializer _valueDeserializer;
     private readonly ITypeConverter _reflectionTypeConverter = new ReflectionTypeConverter();
 
-    public IList<INodeDeserializer> NodeDeserializers { get; private set; }
-    public IList<INodeTypeResolver> TypeResolvers { get; private set; }
+    public IList<INodeDeserializer> NodeDeserializers { get; }
+    public IList<INodeTypeResolver> TypeResolvers { get; }
     public IValueDeserializer ValueDeserializer => _valueDeserializer;
 
     private sealed class TypeDescriptorProxy : ITypeInspector

diff --git a/test/Docfx.Build.SchemaDriven.Tests/SchemaFragmentsIteratorTest.cs b/test/Docfx.Build.SchemaDriven.Tests/SchemaFragmentsIteratorTest.cs
@@ -36,11 +36,11 @@ public void TestSchemaFragmentsIterator()
 
     private class UidPropertyCounter : ISchemaFragmentsHandler
     {
-        public List<string> ExistingMarkdownProperties { get; private set; } = [];
+        public List<string> ExistingMarkdownProperties { get; } = [];
 
-        public List<string> MissingMarkdownProperties { get; private set; } = [];
+        public List<string> MissingMarkdownProperties { get; } = [];
 
-        public List<string> ExistingUids { get; private set; } = [];
+        public List<string> ExistingUids { get; } = [];
 
         public void HandleUid(string uidKey, YamlMappingNode node, Dictionary<string, MarkdownFragment> fragments, BaseSchema schema, string oPathPrefix, string uid)
         {