From 28b1ab1bdd9e36f2495f3703ab40611d9a656ba9 Mon Sep 17 00:00:00 2001 From: Yufei Huang Date: Sat, 6 Jan 2024 11:12:15 +0800 Subject: [PATCH] fix: warn on PDF timeout (#9586) --- src/Docfx.App/PdfBuilder.cs | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/Docfx.App/PdfBuilder.cs b/src/Docfx.App/PdfBuilder.cs index 3f852697ce9..ac4440c2934 100644 --- a/src/Docfx.App/PdfBuilder.cs +++ b/src/Docfx.App/PdfBuilder.cs @@ -155,9 +155,16 @@ IResult TocPage(string url) if (response is null || !response.Ok) throw new InvalidOperationException($"Failed to build PDF page [{response?.Status}]: {url}"); - await page.AddScriptTagAsync(new() { Content = EnsureHeadingAnchorScript }); - await page.WaitForFunctionAsync("!window.docfx || window.docfx.ready"); - await page.WaitForLoadStateAsync(LoadState.NetworkIdle); + try + { + await page.AddScriptTagAsync(new() { Content = EnsureHeadingAnchorScript }); + await page.WaitForFunctionAsync("!window.docfx || window.docfx.ready"); + await page.WaitForLoadStateAsync(LoadState.NetworkIdle); + } + catch (TimeoutException) + { + Logger.LogWarning($"Timeout waiting for page to load, generated PDF page may be incomplete: {url}"); + } return await page.PdfAsync(); }