-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET Aspire is stuck on OpenTelemetry 1.9.0 #7123
Comments
Might be worth talking to some of your coworkers about fixing the OTel upstream side 🤷♂️. |
These seems like a reasonable thing to do as we can do it in the template source so new projects on |
+1 on splitting based on the TFM In this case the split is not too disruptive either (a few conditionals in code) |
We haven't updated our dependeny on OpenTelemetry past
1.9.0
because1.10.0
introduces dependencies that "lift" assemblies out of the shared framework. See [bug] targets other than net9.0 shouldn't be forced to use 9.0 dependencies (open-telemetry/opentelemetry-dotnet#5973) for more information.We should decide what to do with this dependency. The major consumer of these packages is our templates in the ServiceDefaults project.
Should we upgrade to the new version even though we know it will "lift" Microsoft.Extensions.*, System.Diagnostics.DiagnosticsSource, • System.IO.Pipelines, System.Text.Encodings.Web, and System.Text.Json assemblies out of the shared framework?
Should we stay on the 1.9.0 version, and customers can update to the new versions if they want?
Should we split based on the TFM, and only use the new version if the app is targeting
net9.0
?cc @joperezr @DamianEdwards @samsp-msft
The text was updated successfully, but these errors were encountered: