Skip to content

Commit b536b5f

Browse files
committed
Merge pull request #28 from AArnott/fix25
Append git commit ID to all NuGet packages
2 parents 97e4f88 + 3ad8cf0 commit b536b5f

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

src/NerdBank.GitVersioning.Tests/BuildIntegrationTests.cs

+1-4
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,6 @@ public async Task GetBuildVersion_StablePreRelease()
123123
this.AddCommits(this.random.Next(15));
124124
var buildResult = await this.BuildAsync();
125125
this.AssertStandardProperties(VersionOptions.FromVersion(new Version(majorMinorVersion)), buildResult);
126-
127-
Version version = this.Repo.Head.Commits.First().GetIdAsVersion();
128-
Assert.Equal($"{version.Major}.{version.Minor}.{buildResult.GitHeight}", buildResult.NuGetPackageVersion);
129126
}
130127

131128
[Fact]
@@ -233,7 +230,7 @@ private void AssertStandardProperties(VersionOptions versionOptions, BuildResult
233230
Assert.Equal(versionOptions.Version.Prerelease, buildResult.PrereleaseVersion);
234231
Assert.Equal($"+g{commitIdShort}", buildResult.SemVerBuildSuffix);
235232

236-
string pkgVersionSuffix = (buildResult.PublicRelease || string.IsNullOrEmpty(versionOptions.Version.Prerelease))
233+
string pkgVersionSuffix = buildResult.PublicRelease
237234
? string.Empty
238235
: $"-g{commitIdShort}";
239236
Assert.Equal($"{idAsVersion.Major}.{idAsVersion.Minor}.{idAsVersion.Build}{versionOptions.Version.Prerelease}{pkgVersionSuffix}", buildResult.NuGetPackageVersion);

src/Nerdbank.GitVersioning.NuGet/build/NerdBank.GitVersioning.targets

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050

5151
<!-- For unreleased versions (not expected to follow linear history), append the git commit id.
5252
The 'g' prefix allows tooling to recognize that a git commit ID follows. -->
53-
<NuGetPackageVersion Condition=" '$(PublicRelease)' != 'true' and '$(PrereleaseVersion)' != '' ">$(NuGetPackageVersion)-g$(GitCommitIdShort)</NuGetPackageVersion>
53+
<NuGetPackageVersion Condition=" '$(PublicRelease)' != 'true' ">$(NuGetPackageVersion)-g$(GitCommitIdShort)</NuGetPackageVersion>
5454
</PropertyGroup>
5555

5656
<Warning Condition=" '$(AssemblyInformationalVersion)' == '' " Text="Unable to determine the git HEAD commit ID to use for informational version number." />

0 commit comments

Comments
 (0)