Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency detekt to v1.23.8 #1569

Merged
merged 1 commit into from
Feb 26, 2025

Update dependency detekt to v1.23.8

603142f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Update dependency detekt to v1.23.8 #1569

Update dependency detekt to v1.23.8
603142f
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Reports succeeded Feb 26, 2025 in 0s

29 passed, 0 failed and 0 skipped

Tests passed successfully

Report Passed Failed Skipped Time
all-reports/facts-instrumentation-tests-reports/testDebugWithEmulatorWtf/results.xml 4✅ 13s
all-reports/search-instrumentation-tests-reports/testDebugWithEmulatorWtf/results.xml 4✅ 20s
all-reports/unit-tests-reports/junit/TEST-io.dotanuki.features.facts.presentation.FactsViewModelTests.xml 3✅ 18s
all-reports/unit-tests-reports/junit/TEST-io.dotanuki.features.search.domain.SearchQueryValidationTests.xml 1✅ 84ms
all-reports/unit-tests-reports/junit/TEST-io.dotanuki.features.search.presentation.SearchViewModelTests.xml 3✅ 17s
all-reports/unit-tests-reports/junit/TEST-io.dotanuki.platform.android.core.persistence.LocalStorageTests.xml 3✅ 14s
all-reports/unit-tests-reports/junit/TEST-io.dotanuki.platform.jvm.core.rest.internal.NetworkingErrorAwareExecutionTests.xml 1✅ 3ms
all-reports/unit-tests-reports/junit/TEST-io.dotanuki.platform.jvm.core.rest.internal.transformers.ConnectivityErrorTransformerTests.xml 2✅ 2ms
all-reports/unit-tests-reports/junit/TEST-io.dotanuki.platform.jvm.core.rest.internal.transformers.DataMarshallingErrorTransformerTests.xml 2✅ 0ms
all-reports/unit-tests-reports/junit/TEST-io.dotanuki.platform.jvm.core.rest.internal.transformers.RestfulErrorTransformerTests.xml 2✅ 1ms
all-reports/unit-tests-reports/junit/TEST-io.dotanuki.platform.jvm.core.rest.RestClientTests.xml 4✅ 24s

✅ all-reports/facts-instrumentation-tests-reports/testDebugWithEmulatorWtf/results.xml

4 tests were completed in 13s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
run (Pixel2 31) 4✅ 13s

✅ run (Pixel2 31)

io.dotanuki.features.facts.FactsAcceptanceTests
  ✅ testFactsActivity
io.dotanuki.features.facts.FactsScreenshotTests
  ✅ emptyState
  ✅ successState
  ✅ errorState

✅ all-reports/search-instrumentation-tests-reports/testDebugWithEmulatorWtf/results.xml

4 tests were completed in 20s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
run (Pixel2 31) 4✅ 20s

✅ run (Pixel2 31)

io.dotanuki.features.search.SearchAcceptanceTests
  ✅ shouldPerformSearch_ByChoosingASuggestion
  ✅ shouldPerformASearch_ByTypingATerm
io.dotanuki.features.search.SearchScreenshotTests
  ✅ contentWithHistory
  ✅ errorState

✅ all-reports/unit-tests-reports/junit/TEST-io.dotanuki.features.facts.presentation.FactsViewModelTests.xml

3 tests were completed in 18s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
io.dotanuki.features.facts.presentation.FactsViewModelTests 3✅ 18s

✅ io.dotanuki.features.facts.presentation.FactsViewModelTests

✅ at first lunch, should start on empty state
✅ given a successful a search, should emit results
✅ given an unsuccessful a search, should emit error

✅ all-reports/unit-tests-reports/junit/TEST-io.dotanuki.features.search.domain.SearchQueryValidationTests.xml

1 tests were completed in 84ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
io.dotanuki.features.search.domain.SearchQueryValidationTests 1✅ 84ms

✅ io.dotanuki.features.search.domain.SearchQueryValidationTests

✅ should validate query

✅ all-reports/unit-tests-reports/junit/TEST-io.dotanuki.features.search.presentation.SearchViewModelTests.xml

3 tests were completed in 17s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
io.dotanuki.features.search.presentation.SearchViewModelTests 3✅ 17s

✅ io.dotanuki.features.search.presentation.SearchViewModelTests

✅ should proceed saving term chosen from suggestions
✅ should emit error when loading suggestions
✅ at first lunch should display only suggestions

✅ all-reports/unit-tests-reports/junit/TEST-io.dotanuki.platform.android.core.persistence.LocalStorageTests.xml

3 tests were completed in 14s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
io.dotanuki.platform.android.core.persistence.LocalStorageTests 3✅ 14s

✅ io.dotanuki.platform.android.core.persistence.LocalStorageTests

✅ should store new search term
✅ should not persist the same term more than once
✅ should retrieve empty search history

✅ all-reports/unit-tests-reports/junit/TEST-io.dotanuki.platform.jvm.core.rest.internal.NetworkingErrorAwareExecutionTests.xml

1 tests were completed in 3ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
io.dotanuki.platform.jvm.core.rest.internal.NetworkingErrorAwareExecutionTests 1✅ 3ms

✅ io.dotanuki.platform.jvm.core.rest.internal.NetworkingErrorAwareExecutionTests

✅ should transform downstream error with managed execution

✅ all-reports/unit-tests-reports/junit/TEST-io.dotanuki.platform.jvm.core.rest.internal.transformers.ConnectivityErrorTransformerTests.xml

2 tests were completed in 2ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
io.dotanuki.platform.jvm.core.rest.internal.transformers.ConnectivityErrorTransformerTests 2✅ 2ms

✅ io.dotanuki.platform.jvm.core.rest.internal.transformers.ConnectivityErrorTransformerTests

✅ should transform connectivity errors surfaced by the HTTP stack
✅ should propagate any other error

✅ all-reports/unit-tests-reports/junit/TEST-io.dotanuki.platform.jvm.core.rest.internal.transformers.DataMarshallingErrorTransformerTests.xml

2 tests were completed in 0ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
io.dotanuki.platform.jvm.core.rest.internal.transformers.DataMarshallingErrorTransformerTests 2✅ 0ms

✅ io.dotanuki.platform.jvm.core.rest.internal.transformers.DataMarshallingErrorTransformerTests

✅ should not handle any other errors
✅ should transform serialization-related errors

✅ all-reports/unit-tests-reports/junit/TEST-io.dotanuki.platform.jvm.core.rest.internal.transformers.RestfulErrorTransformerTests.xml

2 tests were completed in 1ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
io.dotanuki.platform.jvm.core.rest.internal.transformers.RestfulErrorTransformerTests 2✅ 1ms

✅ io.dotanuki.platform.jvm.core.rest.internal.transformers.RestfulErrorTransformerTests

✅ should transform http error from downstream
✅ should propagate any other error

✅ all-reports/unit-tests-reports/junit/TEST-io.dotanuki.platform.jvm.core.rest.RestClientTests.xml

4 tests were completed in 24s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
io.dotanuki.platform.jvm.core.rest.RestClientTests 4✅ 24s

✅ io.dotanuki.platform.jvm.core.rest.RestClientTests

✅ should recover from latency in the network
✅ should recover from network timeouts
✅ should recover from connection spikes
✅ should not recover from HTTP errors