Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove calls to ptln() in order to remove deprecation warnings #367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChaosKid42
Copy link

This PR remove calls to ptln() which cause deprecation warnings.

Copy link
Member

@michitux michitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In PHP, echo is a statement and not a function. The manual explicitly advices against this function-like syntax even though it is valid when using just a single argument. Also, I think while you paid attention to keep the spaces intact, this removes all line breaks in the output. I didn't check if this has any effect, but I believe either both spaces and line breaks should be preserved, or none of them. I don't see the point in keeping spaces for indentation without line breaks between the lines.

@ChaosKid42 ChaosKid42 force-pushed the fix_deprecation_of_ptln branch from 3bcf745 to 17836ba Compare February 18, 2025 15:02
@ChaosKid42 ChaosKid42 closed this Feb 18, 2025
@ChaosKid42 ChaosKid42 force-pushed the fix_deprecation_of_ptln branch from 17836ba to 4c84b61 Compare February 18, 2025 15:28
@ChaosKid42 ChaosKid42 reopened this Feb 18, 2025
@ChaosKid42 ChaosKid42 force-pushed the fix_deprecation_of_ptln branch from 794ba2e to 33cc143 Compare February 18, 2025 15:37
@ChaosKid42
Copy link
Author

ChaosKid42 commented Feb 18, 2025

In PHP, echo is a statement and not a function. The manual explicitly advices against this function-like syntax even though it is valid when using just a single argument. Also, I think while you paid attention to keep the spaces intact, this removes all line breaks in the output. I didn't check if this has any effect, but I believe either both spaces and line breaks should be preserved, or none of them. I don't see the point in keeping spaces for indentation without line breaks between the lines.

@michitux You are right. I tried another approach.

@ChaosKid42 ChaosKid42 force-pushed the fix_deprecation_of_ptln branch from 33cc143 to aaeb121 Compare February 18, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants