fix(torii-grpc): event processing subscription

[Larkooo]

Summary by CodeRabbit

• Bug Fixes
  • Improved data processing by removing empty strings during event filtering, enhancing robustness of event handling.

[coderabbitai]

Walkthrough

Ohayo, sensei! The changes involve adding a filtering mechanism in the process_event method to remove empty strings when splitting keys and data fields. This ensures that only non-empty strings are processed further, preventing potential issues with empty values during data mapping. The modification enhances the robustness of event processing without altering the method's core functionality or public interfaces.

Changes

File	Change Summary
crates/torii/grpc/src/server/subscriptions/event.rs	Added `.filter(

The change is a simple yet effective data cleaning step that prevents processing of empty string results from splitting operations.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

crates/torii/grpc/src/server/subscriptions/event.rs (1)

99-111: Consider enhancing error reporting for debugging.

Ohayo sensei! While the filtering approach is solid, consider adding debug logging when empty strings are filtered out. This could help diagnose issues if the input data quality degrades.

Here's a suggested enhancement:

             .split(SQL_FELT_DELIMITER)
-            .filter(|s| !s.is_empty())
+            .filter(|s| {
+                if s.is_empty() {
+                    trace!(target = LOG_TARGET, "Filtered empty string in keys");
+                    false
+                } else {
+                    true
+                }
+            })
             .map(Felt::from_str)
             .collect::<Result<Vec<_>, _>>()
             .map_err(ParseError::from)?;
         let data = event
             .data
             .trim_end_matches(SQL_FELT_DELIMITER)
             .split(SQL_FELT_DELIMITER)
-            .filter(|s| !s.is_empty())
+            .filter(|s| {
+                if s.is_empty() {
+                    trace!(target = LOG_TARGET, "Filtered empty string in data");
+                    false
+                } else {
+                    true
+                }
+            })

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0adbcdd and 597c3f6.

📒 Files selected for processing (1)

• crates/torii/grpc/src/server/subscriptions/event.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: ensure-wasm
• GitHub Check: build
• GitHub Check: clippy
• GitHub Check: docs

🔇 Additional comments (2)

crates/torii/grpc/src/server/subscriptions/event.rs (2)

100-100: Ohayo! Good defensive programming, sensei!

Adding the filter to remove empty strings before converting to Felt is a robust approach. This prevents potential parsing errors from empty strings in the keys field.

---

108-108: Nice consistency in error handling!

The same filtering approach is correctly applied to the data field, maintaining consistency in how empty strings are handled.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.12%. Comparing base (bc88734) to head (597c3f6).
Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
...rates/torii/grpc/src/server/subscriptions/event.rs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2975      +/-   ##
==========================================
- Coverage   57.20%   57.12%   -0.08%     
==========================================
  Files         423      424       +1     
  Lines       56125    56200      +75     
==========================================
- Hits        32104    32103       -1     
- Misses      24021    24097      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.