Skip to content
This repository was archived by the owner on Jul 30, 2018. It is now read-only.

Integrate dojo/diagnostics into dojo/widget-core #5

Open
edhager opened this issue Jan 29, 2018 · 1 comment
Open

Integrate dojo/diagnostics into dojo/widget-core #5

edhager opened this issue Jan 29, 2018 · 1 comment

Comments

@edhager
Copy link

edhager commented Jan 29, 2018

Create a new version of dojo/diagnostics that can be integrated into dojo/widget-core to produce messages that can be consumed by a browser plug-in.

Here are some requirements that must be fulfilled:

  • Calls to the diagnostics API from Dojo libraries must follow a syntax that can be identified and removed by the Dojo 2 builder (Webpack). A suggestion... Use the dojo/has library to wrap the diagnostics calls. The Dojo 2 builder already has the capability to remove code based on feature detection.
if(has('diagnostics')) { diaganostics.log(...) }
  • Use postMessage to publish messages but also allow for messages to be transmitted via a web socket in the future for remote debugging.

For the initial implementation, publish a message that notifies when the virtual DOM is created/updated. Include the virtual DOM tree in the message.

Create a pull request that contains the modification to widget-core so it can be reviewed by the rest of the Dojo 2 team.

@rorticus
Copy link

rorticus commented Mar 2, 2018

Something to consider,

dojo/widget-core@master...rorticus:diagnostics

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants