Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added most of the chinese translations #227

Open
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from

Conversation

DetectiveKarenthy
Copy link

Description

Added most of the Chinese Simplified translations. Some of the text are not used anymore in json file and therefore not translated.

Motivation and Context

The Chinese Simplified language is not present yet.

How Has This Been Tested?

No change of any functional code, only the language is added.

Checklist:

  • Some of the strings are hardcoded in the HTML file, those are not and cannot be translated.
  • Some strings are obsolete in json file (not used anywhere). Please purge the json file and then I can continue translation.

Copy link

@bobdos bobdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some comments

@bobdos
Copy link

bobdos commented May 16, 2021

  • please add both of index.html and guide.html as well;
  • please change cn.json to zh-cn.json;
  • will add more comments soon.

thanks for your effort.

@DetectiveKarenthy
Copy link
Author

@bobdos @valentcheung Thanks for the comments. I've updated accordingly.

@langerhans
Copy link
Member

Is this ready for review now?

@DetectiveKarenthy
Copy link
Author

@langerhans From my side it is ready. Again not all entries are translated in the JSON file as they do not appear anywhere on the website. Existing comments have been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants