Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zh-HK Chinese (Hong Kong Cantonese) support. #224

Open
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from

Conversation

valentcheung
Copy link

@valentcheung valentcheung commented May 15, 2021

Description

  • Added zh-HK Chinese (Hong Kong Cantonese) support.
  • Updated locale dropdown in Support.html

Motivation and Context

Closes #223 A wider audience will be reached

How Has This Been Tested?

All characters display properly.

Checklist:

  • GitHub issue linked
  • The necessary translations have been added for all languages
  • Any documentation has been updated accordingly
  • Responsive sizes (Mobile) tested
  • Cross Browser tested if necessary
  • Conflicts resolved

Copy link

@danielwatkins635 danielwatkins635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as all visible text have been localised and adequate updates to the relevant files have been made to make the localisation available to end users.

aarsxx
aarsxx previously approved these changes May 16, 2021
Copy link

@aarsxx aarsxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valentcheung
Copy link
Author

@langerhans (or others) shall we merge this now? Thanks

@langerhans langerhans dismissed stale reviews from aarsxx and danielwatkins635 via c62aad3 May 17, 2021 18:25
@langerhans
Copy link
Member

There are still a lot of English strings in the file, is that on purpose?

@valentcheung
Copy link
Author

There are still a lot of English strings in the file, is that on purpose?

If we are planning to reveal those to public, I can translate them. But since none of those are shown at all in any of the pages, they're left here for now.

@valentcheung
Copy link
Author

@langerhans shall we have this merged? feel free to suggest changes, cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Hong Kong Chinese support
4 participants