-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zh-HK Chinese (Hong Kong Cantonese) support. #224
base: gh-pages
Are you sure you want to change the base?
Conversation
Add zh-HK Chinese (Hong Kong Cantonese) support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as all visible text have been localised and adequate updates to the relevant files have been made to make the localisation available to end users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@langerhans (or others) shall we merge this now? Thanks |
There are still a lot of English strings in the file, is that on purpose? |
If we are planning to reveal those to public, I can translate them. But since none of those are shown at all in any of the pages, they're left here for now. |
@langerhans shall we have this merged? feel free to suggest changes, cheers |
Description
Motivation and Context
Closes #223 A wider audience will be reached
How Has This Been Tested?
All characters display properly.
Checklist: