Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI changes and language dropdown #164

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

hoxhaj
Copy link

@hoxhaj hoxhaj commented Apr 29, 2021

Description

UI changes and language dropdown

Motivation and Context

Resolves #163

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • GitHub issue linked
  • The necessary translations have been added for all languages
  • Any documentation has been updated accordingly
  • Responsive sizes (Mobile) tested
  • Cross Browser tested if necessary
  • Conflicts resolved

@magneticat
Copy link
Contributor

magneticat commented May 3, 2021

Hello @hoxhaj I am having a problem with the dropdown edits in which when I click on the select box, before selecting anything, I am sent back to the top of the page. There is also a very simple bootstrap implementation for the dropdown which might do the trick and fit a bit better with the style of the page. I will try a pull request and you can review it. Your other edits can be discussed in a separate issue maybe?

@hoxhaj
Copy link
Author

hoxhaj commented May 3, 2021

Hi @magneticat! I think your issue is related to the click event on the select-lang class on the script.js file (try to put the select-lang class in the div where dropdown-menu class is located, i haven't tested). Anyway i made some changes on my code to fit better to the page layout. Maybe for a language selector fits better the select element because you can always check which language is active at the moment. The other changes were made just to give some kind of order on the elements of the page, at least in my opinion.

@patricklodder
Copy link
Member

Can you rebase this against the main branch after the merge I did to use the bootstrap native dropdown? Then this would be good to go!

Sorry to make you rebase twice!

Copy link

@aarsxx aarsxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown Selector for Languages
4 participants