Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate to Simplified Chinese #106

Closed
wants to merge 1 commit into from
Closed

Conversation

aohas
Copy link

@aohas aohas commented May 29, 2017

Adding Chinese translation to the website
增加网站的中文翻译

@DodoShen
Copy link

I could help with tranditional Chinese.

@bobdos
Copy link

bobdos commented May 10, 2021

I can help to review the Simplified Chinese one.

@rnicoll
Copy link
Contributor

rnicoll commented May 10, 2021

Please note this is a translation of the very old website. If someone can use this as a base but update against the latest website version, it would be appreciated.

@bobdos
Copy link

bobdos commented May 10, 2021

Please note this is a translation of the very old website. If someone can use this as a base but update against the latest website version, it would be appreciated.

Got it, @rnicoll

So, should we submit a total new pull request, or update this pull request directly?

@rnicoll
Copy link
Contributor

rnicoll commented May 10, 2021

If the original author isn't around, probably easiest to make a new PR. If you rebase the original commit they'll still get credit for their work, and then it's just updating it to the new site content

@bobdos
Copy link

bobdos commented May 11, 2021

If the original author isn't around, probably easiest to make a new PR. If you rebase the original commit they'll still get credit for their work, and then it's just updating it to the new site content

Got it @rnicoll I shall open a new pull request soon, easier to follow the latest site info, to avoid distraction if based on the old ones.

@langerhans
Copy link
Member

Closing in favor of #227

@langerhans langerhans closed this May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants