Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildKit set as default builder since 3.2.x #5458

Closed
3 tasks done
andreyzher opened this issue Mar 15, 2021 · 6 comments · Fixed by docker/docs#12505
Closed
3 tasks done

BuildKit set as default builder since 3.2.x #5458

andreyzher opened this issue Mar 15, 2021 · 6 comments · Fixed by docker/docs#12505

Comments

@andreyzher
Copy link

  • I have tried with the latest version of Docker Desktop
  • I have tried disabling enabled experimental features
  • I have uploaded Diagnostics
  • Diagnostics ID: 74E6F0AA-305E-4111-8E5F-55FDA86DB953/20210315162132

Expected behavior

Docker BuildKit should be on opt-in basis according to documentation

Actual behavior

Docker BuildKit is default builder since 3.2.x

Information

  • macOS Version: Big Sur 11.2.3
  • Docker Desktop Version: 3.2.2

In Docker Desktop 3.1.x the BuildKit builder was on opt-in basis.

I checked the release notes for Docker Desktop for Mac and there is nothing indicating this change in behaviour, and this only seems to be affecting Mac packages - I was unable to reproduce on a CentOS VM.

If this was intentional, it should be called out in the release notes as some images will fail to build with BuildKit enabled ( specifically sclorg/s2i-base-container#207 )

Steps to reproduce the behavior

  1. Upgrade to Docker Desktop for Mac >= 3.2.0
  2. Build any Docker image

Dockerfile:

FROM centos:7
LABEL foo bar

Command: docker build -t foo-bar .

@stephen-turner
Copy link
Contributor

It's been the default for new installations (or on a factory reset) since 2.4 (see https://docs.docker.com/docker-for-mac/release-notes/#docker-desktop-community-2400). But we just made it the default for existing installations too. You're right, we should have mentioned it. It can still be turned off in the engine settings if you need to.

@andreyzher
Copy link
Author

I see. Didn't think to scroll back to 2.4 that it was the new default for new installs .

Thanks for confirming - I thought I was going mad.

@stephen-turner
Copy link
Contributor

I've raised a PR against the docs, docker/docs#12505.

@andreyzher
Copy link
Author

Thanks for the quick turnaround updating the docs!

Do you know if the same change could be expected to the Linux installs any time soon?

@stephen-turner
Copy link
Contributor

I believe they're discussing it, but I'm afraid I don't know the timeline.

@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle locked

@docker docker locked and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants