Added templating #302
Merged
Added templating #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentGoderre
force-pushed
the
templating
branch
from
8754a48 to
41ff6e8
Compare
Merged
LaurentGoderre
force-pushed
the
templating
branch
from
41ff6e8 to
dce1e49
Compare
|
What is missing so that this PR (and dependend (#304)) can be merged? |
$ diff -u ~/official-images/library/redmine <(./generate-stackbrew-library.sh)
--- ~/official-images/library/redmine 2023-10-25 16:18:54.723081347 -0700
+++ /dev/fd/63 2023-11-17 16:02:16.190765017 -0800
@@ -1,15 +1,15 @@
-# this file is generated via https://github.com/docker-library/redmine/blob/540786b2e371dcfb74be6da6bc2a77f75d9d6b07/generate-stackbrew-library.sh
+# this file is generated via https://github.com/docker-library/redmine/blob/dce1e4913a56091ef1ccd05d1e9df88fa75bce64/generate-stackbrew-library.sh
Maintainers: Tianon Gravi <admwiggin@gmail.com> (@tianon),
Joseph Ferguson <yosifkit@gmail.com> (@yosifkit)
GitRepo: https://github.com/docker-library/redmine.git
Tags: 5.0.6, 5.0, 5, latest, 5.0.6-bookworm, 5.0-bookworm, 5-bookworm, bookworm
-Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x
-GitCommit: 329d3b89cc5ef11e7363f3eaff0f046e249aadee
-Directory: 5.0
+Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x
+GitCommit: dce1e4913a56091ef1ccd05d1e9df88fa75bce64
+Directory: 5.0/bookworm
-Tags: 5.0.6-alpine, 5.0-alpine, 5-alpine, alpine, 5.0.6-alpine3.18, 5.0-alpine3.18, 5-alpine3.18, alpine3.18
+Tags: 5.0.6-alpine3.18, 5.0-alpine3.18, 5-alpine3.18, alpine3.18, 5.0.6-alpine, 5.0-alpine, 5-alpine, alpine
Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le, s390x
-GitCommit: 329d3b89cc5ef11e7363f3eaff0f046e249aadee
-Directory: 5.0/alpine
+GitCommit: dce1e4913a56091ef1ccd05d1e9df88fa75bce64
+Directory: 5.0/alpine3.18👀 |
yosifkit
reviewed
Nov 18, 2023
| fi | ||
| versions=( "${versions[@]%/}" ) | ||
|
|
||
| releasesUrl='https://www.redmine.org/releases' |
There was a problem hiding this comment.
Since this is dropping the Redmine wiki scraping added in #257, we'll need to keep an eye out that we don't miss a version bump.
yosifkit
approved these changes
Nov 18, 2023
yosifkit
added a commit
to infosiftr/oi-janky-groovy
that referenced
this pull request
Nov 18, 2023
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Nov 18, 2023
Changes: - docker-library/redmine@43ac7c9: Merge pull request docker-library/redmine#302 from LaurentGoderre/templating - docker-library/redmine@e57ff5c: Space cleanup; move fetch_package_list function call - docker-library/redmine@dce1e49: Added templating
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Nov 18, 2023
Changes: - docker-library/redmine@0fdd086: Merge pull request docker-library/redmine#304 from LaurentGoderre/v5.1 - docker-library/redmine@16d3e00: Add version 5.1.0 - docker-library/redmine@43ac7c9: Merge pull request docker-library/redmine#302 from LaurentGoderre/templating - docker-library/redmine@e57ff5c: Space cleanup; move fetch_package_list function call - docker-library/redmine@dce1e49: Added templating
|
Heh, we forgot the "Verify Templating" job here 👀 Added in 3b163d7 |
tianon
added a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.