fix(Dialog): prevent onClose event from firing in StrictMode when opening a new dialog
#4525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning a new dialog - Also add `handler` to `triggeredBy` when the `close` method is called. - Improve the documentation of the `triggeredBy` property.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
langz
approved these changes
Feb 1, 2025
tujoworker
pushed a commit
that referenced
this pull request
Feb 4, 2025
## [10.63.2](v10.63.1...v10.63.2) (2025-02-04) ### 🐛 Bug Fixes * **Dialog:** prevent `onClose` event from firing in StrictMode when opening a new dialog ([#4525](#4525)) ([d24c0d3](d24c0d3)) * **Forms:** always revalidate on submit when data context changes ([#4532](#4532)) ([e0692d6](e0692d6)) * **Forms:** ensure `setFieldStatus` by useValidation does not throw when used without id ([#4529](#4529)) ([1a92512](1a92512)) * **Forms:** ensure `update('/path', undefined)` does not show error message ([#4531](#4531)) ([2dfd44a](2dfd44a))
|
🎉 This PR is included in version 10.63.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handlertotriggeredBywhen theclosemethod is called.triggeredByproperty.