chore(Field.Option): remove unused code #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
langz
changed the title
langz
force-pushed
the
chore/remove-unused-code
branch
2 times, most recently
from
0809ce5 to
d92f106
Compare
langz
commented
Jan 29, 2025
packages/dnb-eufemia/src/extensions/forms/Field/Selection/Selection.tsx
Outdated
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
langz
force-pushed
the
chore/remove-unused-code
branch
from
7c976e0 to
22b8df5
Compare
langz
force-pushed
the
chore/remove-unused-code
branch
from
22b8df5 to
a41a069
Compare
langz
changed the title
tujoworker
approved these changes
Jan 29, 2025
|
🎉 This PR is included in version 10.63.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see that the
Field.Optioncode is actually used at all 🤔It's only the types that's used, as the actual JSX code that
Field.Optionhad before this PR would never be ran, it would just be overridden inField.SelectionandField.ArraySelection. And as it says in docs: Field.Option is a pseudo-component that is used by parent components to configure options. It has no use on its own.