-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release of v10.16.0 #3088
Merged
Merged
release of v10.16.0 #3088
+6,168
−6,242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ney_left, teenager (#3064)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ea56957:
|
🔴 Both these cases will with this PR, <img width="367" alt="Screenshot 2023-12-12 at 20 34 11" src="https://github.com/dnbexperience/eufemia/assets/1501870/cca5c56f-761b-47ef-90ab-4677b1eb0e6f"> <img width="372" alt="Screenshot 2023-12-12 at 20 31 56" src="https://github.com/dnbexperience/eufemia/assets/1501870/787af181-8f39-41d1-9393-3a05de97b0cd"> 🟢 result in this: <img width="393" alt="Screenshot 2023-12-12 at 20 07 36" src="https://github.com/dnbexperience/eufemia/assets/1501870/42a2fee8-3156-4c23-999f-2024f07f2de8"> <img width="367" alt="Screenshot 2023-12-12 at 20 36 39" src="https://github.com/dnbexperience/eufemia/assets/1501870/ae30966f-0b0f-4907-a8c4-eff91721f387">
…3109) For data transformation, add these hooks: - `toOutput` - `fromExternal` For custom control about validating the required prop: - `validateRequired` Also, adding docs about the `useDataValue` hook.
Should fix the `onChange` argument type inferred as any from [this slack discussion](https://dnb.enterprise.slack.com/team/WJLKMHXMY) Before: <img width="957" alt="Screenshot 2023-12-19 at 14 38 37" src="https://github.com/dnbexperience/eufemia/assets/25927156/c4147e05-8402-43f7-9a5d-be0e5f9b9964"> After: <img width="511" alt="Screenshot 2023-12-19 at 14 37 57" src="https://github.com/dnbexperience/eufemia/assets/25927156/3df1a3a1-cf5c-49de-a2ed-1335992be3f0"> --------- Co-authored-by: Tobias Høegh <tobias@tujo.no>
Co-authored-by: Tobias Høegh <tobias@tujo.no>
… is required and only country code is provided (#3081) The `Field.PhoneNumber` component renders an validation error initially when it is required and only country code is provided. Git bisect tells me this was introduced in 5b1a9b0. Here is a small example to reproduce it, but see the attached commit for full details. ```jsx <PhoneNumber required value='+47' /> ``` Work around: ```tsx function DemoPhoneNumberField() { const countryCode = '+47' const phoneNumber = '' const value = (countryCode === '+47' && !phoneNumber) ? undefined : (countryCode + ' ' + phoneNumber) return <PhoneNumber required value={value} /> } ``` --------- Co-authored-by: Tobias Høegh <tobias@tujo.no>
Co-authored-by: Joakim Bjerknes <joakbjerk@gmail.com>
…e based on chosen locale (#3156) Co-authored-by: Tobias Høegh <tobias@tujo.no>
Fixes the following code example, which would result in having a hover style: ``` <Anchor href="/uilib/components/anchor" className="dnb-anchor--no-hover dnb-anchor--contrast" > No hover </Anchor> ``` Looking like: <img width="112" alt="image" src="https://github.com/dnbexperience/eufemia/assets/1359205/4999bf46-6d76-44b9-a008-43490686d3db"> After the fix, it looks like this when hovering: <img width="104" alt="image" src="https://github.com/dnbexperience/eufemia/assets/1359205/7af6bd1b-4094-4ab3-883f-40eb429678f9"> This PR also adds a few screenshot tests for `dnb-anchor--contrast` variations, together with other helper classes. --------- Co-authored-by: Tobias Høegh <tobias@tujo.no>
We need this "refactor" for a upcoming Card component refactoring.
On small screens, the Card should breakout. To be able to do that, we use the Section component.
Co-authored-by: Joakim Bjerknes <joakbjerk@gmail.com>
tujoworker
approved these changes
Jan 4, 2024
🎉 This PR is included in version 10.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main motivation for this release is to make the new icons available. I'm not sure when our consumer "wants it", but some of the newly added icons(in our code) was made available in Figma as early as 3rd of November. So I feel like it would be nice to make these available from Eufemia web quite soon 😅