Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] to_pyg_data should return int64 edge_index. #7178

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Feb 29, 2024

Description

We need this change after #7127 is merged. #7123 depends on this change. PyG expects edge_index to be int64.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin added the Release Blocker Issues that blocks release label Feb 29, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 29, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 29, 2024

Commit ID: ac120d1579237ee806210905fe7f9459ef1f8d40

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit 09e4855 into dmlc:master Mar 1, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_to_pyg_data_dtype_fix branch March 1, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Blocker Issues that blocks release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants