Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt][CUDA] refine the node_classification examples. #7136

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Feb 22, 2024

Description

Fixing minor typos and aligning the multiGPU example with the tutorial updated in #7126.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested a review from frozenbugs February 22, 2024 01:26
@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 22, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@mfbalin
Copy link
Collaborator Author

mfbalin commented Feb 22, 2024

@TristonC you can run the papers100M with the updated multiGPU script in this PR.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 22, 2024

Commit ID: 12ad220989afe68dc45fe27a263d675223af3456

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@mfbalin mfbalin requested a review from Rhett-Ying February 22, 2024 01:32
Co-authored-by: Mingbang Wang <100203018+Skeleton003@users.noreply.github.com>
@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 22, 2024

Commit ID: e90373d493d347d4add15dcd43477e84aa87a316

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 22, 2024

Commit ID: 6bbe6cb38f1d4f2a68a5abd7c038ad43c050817c

Build ID: 3

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 22, 2024

Commit ID: f6308dddcbafb6326c50c3a167c4d02c6b66cd20

Build ID: 4

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 22, 2024

Commit ID: 2bbc93d3458112f1d52f078bd663f37706c43cdb

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@frozenbugs frozenbugs requested a review from RamonZhou February 22, 2024 04:22
@frozenbugs
Copy link
Collaborator

LGTM @RamonZhou please take a second look and approve.

Copy link
Collaborator

@RamonZhou RamonZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfbalin mfbalin merged commit 8909d1f into dmlc:master Feb 23, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_cuda_refine_examples branch February 23, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants