Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Modify exclude_seed_edges to support seeds. #7114

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

yxy235
Copy link
Collaborator

@yxy235 yxy235 commented Feb 9, 2024

Description

  1. Add add_reverse_edges_2 to support seeds format.
  2. Add _exclude_homo_edges to support seeds format.
  3. Add tests to test function in utils.py.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@yxy235 yxy235 requested a review from frozenbugs February 9, 2024 07:59
@yxy235 yxy235 linked an issue Feb 9, 2024 that may be closed by this pull request
@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 9, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@yxy235 yxy235 force-pushed the seed_exclude_edges branch from ffa3000 to a18a603 Compare February 9, 2024 08:03
@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 9, 2024

Commit ID: bf150a79e27d0a25e0fc420b363fbc45de773c8e

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 9, 2024

Commit ID: a18a603

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@yxy235 yxy235 force-pushed the seed_exclude_edges branch from a18a603 to ea848d5 Compare February 19, 2024 06:26
@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 19, 2024

Commit ID: ea848d5

Build ID: 3

Status: ❌ CI test failed in Stage [Torch CPU Example test].

Report path: link

Full logs path: link

@yxy235
Copy link
Collaborator Author

yxy235 commented Feb 19, 2024

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 19, 2024

Commit ID: ea848d5

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@yxy235 yxy235 merged commit 4440ac7 into dmlc:master Feb 22, 2024
2 checks passed
@yxy235 yxy235 deleted the seed_exclude_edges branch April 30, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GraphBolt] Support seeds in SubgraphSampler.
3 participants