-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit of Components #766
Open
dmjio
wants to merge
10
commits into
master
Choose a base branch
from
components
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+882
−455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds Component existential wrapper used for nesting App - Adds `notify` for bidirectional communication between components (parent, child or siblings) - Modifies diff.js to mount / unmount components - Creates top-level ComponentMap used to store sinks and threads for each Component - Adds components example (modified from simple.jsexe) - Renames Notify to Waiter (reuse 'notify' elsewhere) - Creates Miso.Internal
Let's go! |
Perhaps effectful can be a useful guide/inspiration on how to implement static safety? |
@brakubraku Will check it out. We have options. Want to keep it simple for the LLMs too. You can join our matrix server if you want to discuss more. |
- Update interface for haskell-miso
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍜 Miso Components
Adds React-style components to Miso. This allows the embedding of
App
withinApp
using an existential wrapperComponent
implemented as a new branch of theView
tree.API
Example usage
Component
existential wrapper used for nestingApp
notify
for bidirectional communication between components (parent, child or siblings)ComponentMap
used to store sinks and threads for eachComponent
simple.jsexe
)Notify
toWaiter
(reuse 'notify' elsewhere)Miso.Internal
Outstanding:
Key
onComponent
Component
mounting and unmounting, and syncChildrenEffect
to be aState
monad som
won't be required for use withnotify
diff.js
examples/components
onMounted
,onUnmounted
,onBefore*
,onAfter*
,onException
, etc.)App
names and mountPoints (e.g.App "todo-app" model action
)Pitfalls:
It is possible to create cycles in the component graph by mutually recursive notifications. This can lead to runaway recursion. No real good way to statically keep this from occurring, yet.
mountPoint
is now used as both the component name and theid
of themountPoint
element. With the exception of top-level App, which is not a Component, and should specify "body", or an element with anid
that already exists.Component names must be unique, and will be used to create a
div
. Consider somehow making this type safe.