Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional validation rule to provide a bad request when more than just the default channel #957

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

JackLewis-digirati
Copy link
Contributor

@JackLewis-digirati JackLewis-digirati commented Feb 10, 2025

This PR simply adds an additional hydra validator that will stop allowing the default channel to be specified with other channels, mimicking the behaviour of the none channel

@JackLewis-digirati JackLewis-digirati marked this pull request as ready for review February 10, 2025 15:57
@JackLewis-digirati JackLewis-digirati requested a review from a team as a code owner February 10, 2025 15:57
Copy link
Member

@donaldgray donaldgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Should HydraImageValidatorTests gain a test too?

@JackLewis-digirati JackLewis-digirati merged commit 5cbd022 into main Feb 10, 2025
10 checks passed
@JackLewis-digirati JackLewis-digirati deleted the fix/disableAdditionalChannelsToDefault branch February 10, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants