Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include custom fields, tags, and roles in single item/named query manifests #702

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Include custom fields, tags, and roles in single item/named query manifests #702

merged 4 commits into from
Jan 11, 2024

Conversation

griffri
Copy link
Contributor

@griffri griffri commented Jan 3, 2024 •
edited
Loading

Resolves #698

This PR includes custom fields, as well as roles and tags in asset manifests constructed by IIIFCanvasFactory.

Example in Universal Viewer:
image

@griffri griffri changed the title Include custom fields, tags, and roles in single issue/named query manifest Include custom fields, tags, and roles in single item/named query manifest Jan 3, 2024
@griffri griffri changed the title Include custom fields, tags, and roles in single item/named query manifest Include custom fields, tags, and roles in single item/named query manifests Jan 3, 2024
@griffri griffri force-pushed the feature/manifest_asset_customfields branch 2 times, most recently from 30f0632 to f2af2d1 Compare January 4, 2024 14:43
@griffri griffri marked this pull request as ready for review January 4, 2024 14:56
@griffri griffri requested a review from a team as a code owner January 4, 2024 14:56
@griffri griffri force-pushed the feature/manifest_asset_customfields branch from a83d40c to 0921d42 Compare January 5, 2024 16:58
donaldgray
donaldgray approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@donaldgray donaldgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding tests to validate metadata is added?

@griffri
Copy link
Contributor Author

griffri commented Jan 8, 2024

Is it worth adding tests to validate metadata is added?

I think so. I'll add this in.

@griffri griffri merged commit 3e584e7 into main Jan 11, 2024
9 checks passed
@donaldgray donaldgray deleted the feature/manifest_asset_customfields branch January 22, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldgray donaldgray donaldgray approved these changes

@tomcrane tomcrane Awaiting requested review from tomcrane tomcrane was automatically assigned from dlcs/dlcs-developers

@JackLewis-digirati JackLewis-digirati Awaiting requested review from JackLewis-digirati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include all custom fields in single issue manifest and named queries
3 participants
@griffri @donaldgray @JackLewis-digirati