You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add support for manifest NamedQuery config parameter. E.g. manifest=s1.
This can be a comma-delimited list of values (similar to batch, see #930).
Despite the name, this is a property that is valid for all projection types - not just IIIF Manifests. As such it should live in ParsedNamedQuery class, rather than IIIFParsedNamedQuery.
Important
manifest is already a NQ parameter!
See #825 for details, manifest is already a NQ parameter and there are a number of existing NQ's that are configured with it. However, the parameter does nothing so can be removed.
This change should ensure that any existing NQs that use manifest=xx in their configuration are updated on deployment, this should only happen on first deployment so a migration is likely the best option.
The update should be something like template.replace('manifest=[\w\d]+', ''), handling for manifest being the first/last/middle argument.
How would the migration handle manifest=* being the sole config value? We should check if there are any NQ's where this is the case and decide how to act.
The text was updated successfully, but these errors were encountered:
See RFC.
Add support for
manifest
NamedQuery config parameter. E.g.manifest=s1
.This can be a comma-delimited list of values (similar to
batch
, see #930).Despite the name, this is a property that is valid for all projection types - not just IIIF Manifests. As such it should live in
ParsedNamedQuery
class, rather thanIIIFParsedNamedQuery
.Important
manifest
is already a NQ parameter!See #825 for details,
manifest
is already a NQ parameter and there are a number of existing NQ's that are configured with it. However, the parameter does nothing so can be removed.This change should ensure that any existing NQs that use
manifest=xx
in their configuration are updated on deployment, this should only happen on first deployment so a migration is likely the best option.The update should be something like
template.replace('manifest=[\w\d]+', '')
, handling formanifest
being the first/last/middle argument.manifest=s1&sequence=0&canvas=n1&s1=p1
=>sequence=0&canvas=n1&s1=p1
manifest=s1&sequence=n1&canvas=n2&s1=p1&n1=p2
=>sequence=n1&canvas=n2&s1=p1&n1=p2
How would the migration handle
manifest=*
being the sole config value? We should check if there are any NQ's where this is the case and decide how to act.The text was updated successfully, but these errors were encountered: