Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend NQ support for manifest #955

Open
donaldgray opened this issue Feb 6, 2025 · 0 comments
Open

Extend NQ support for manifest #955

donaldgray opened this issue Feb 6, 2025 · 0 comments
Labels
orchestrator refined Identify refined tickets in the backlog

Comments

@donaldgray
Copy link
Member

donaldgray commented Feb 6, 2025

See RFC.

Add support for manifest NamedQuery config parameter. E.g. manifest=s1.

This can be a comma-delimited list of values (similar to batch, see #930).

Despite the name, this is a property that is valid for all projection types - not just IIIF Manifests. As such it should live in ParsedNamedQuery class, rather than IIIFParsedNamedQuery.

Important

manifest is already a NQ parameter!

See #825 for details, manifest is already a NQ parameter and there are a number of existing NQ's that are configured with it. However, the parameter does nothing so can be removed.

This change should ensure that any existing NQs that use manifest=xx in their configuration are updated on deployment, this should only happen on first deployment so a migration is likely the best option.

The update should be something like template.replace('manifest=[\w\d]+', ''), handling for manifest being the first/last/middle argument.

manifest=s1&sequence=0&canvas=n1&s1=p1 => sequence=0&canvas=n1&s1=p1
manifest=s1&sequence=n1&canvas=n2&s1=p1&n1=p2 => sequence=n1&canvas=n2&s1=p1&n1=p2

How would the migration handle manifest=* being the sole config value? We should check if there are any NQ's where this is the case and decide how to act.

@donaldgray donaldgray added orchestrator refined Identify refined tickets in the backlog labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
orchestrator refined Identify refined tickets in the backlog
Projects
None yet
Development

No branches or pull requests

1 participant