Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify how an eventId should be calculated #20

Closed
benthecarman opened this issue Feb 25, 2020 · 2 comments
Closed

Specify how an eventId should be calculated #20

benthecarman opened this issue Feb 25, 2020 · 2 comments

Comments

@benthecarman
Copy link
Contributor

An eventId should be a unique identifier between the parties in the DLC. Ideally it should be deterministic and should be reliant on the contract as well, to best accomplish this it would likely need to be a hash of the contract info, oracle info, the timeouts/delays, as well as some public keys from the participating parties whether it be each other's funding keys or maybe a lightning public key.

@Tibo-lg
Copy link
Member

Tibo-lg commented Mar 11, 2020

Ah sorry just opened #32 without noticing this one.

@nkohen
Copy link
Contributor

nkohen commented Aug 13, 2020

After further thinking, I ended up proposing in #59 that this should be done the way it is done in lightning (by using the funding output with a temporary id, which I computed as the hash of the offer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants