Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDST-593: Hardening #82

Merged
merged 1 commit into from
Oct 24, 2024
Merged

DDST-593: Hardening #82

merged 1 commit into from
Oct 24, 2024

Conversation

bibliophileaxe
Copy link
Contributor

No description provided.

@bibliophileaxe bibliophileaxe added the patch Backwards compatible bug fixes. label Oct 18, 2024
JojoVes
JojoVes approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@JojoVes JojoVes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane. I'm not sure what situation could involve getting a node parameter that's truthy and not a node, but logically the hardening makes sense regardless.

@nchiasson-dgi nchiasson-dgi merged commit ee03ac0 into main Oct 24, 2024
1 check passed
@nchiasson-dgi nchiasson-dgi deleted the DDST-593 branch October 24, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JojoVes JojoVes JojoVes approved these changes

Assignees
No one assigned
Labels
patch Backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bibliophileaxe @JojoVes @nchiasson-dgi