FIX: Android tablet composer menu z-index #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegangeorge
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keegangeorge I think the more solid fix here would be to add a new class that identifies any
DMenucomponents loaded inside the composer and then setting the right z-index for those elements. This likely should be aDMenuflag in core, and then the AI plugin can use that where applicable. (I know we use these menus outside the composer, so it's not entirely straightforward.)Feel free to take this draft PR and build on it. (Or we can merge this quick fix and follow up at a later time.)
Bug report: https://meta.discourse.org/t/ai-helper-hiding-on-android-tablets/349719