Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Add no-results className to full page search toggle #1055

Merged
merged 2 commits into from
Jan 10, 2025
Merged

DEV: Add no-results className to full page search toggle #1055

merged 2 commits into from
Jan 10, 2025

Conversation

markvanlan
Copy link
Contributor

Needed to customize the colors of the toggle for this state :)

keegangeorge
keegangeorge approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@keegangeorge keegangeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But one small suggestion to improve code a bit while we're updating things here. If you need this sooner though, feel free to merge and follow-up later.

assets/javascripts/discourse/components/ai-full-page-search.gjs Outdated Show resolved Hide resolved
@markvanlan markvanlan merged commit 2d1ce01 into main Jan 10, 2025
6 checks passed
@markvanlan markvanlan deleted the full-page-classes branch January 10, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keegangeorge keegangeorge keegangeorge approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markvanlan @keegangeorge