Issue #761 by Inlead: Consider denial of deniedRenewal a success.

ding2 · Sep 4, 2015 · 9912f4b · 9912f4b
1 parent 2477112
commit 9912f4b
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/AlmaClient/AlmaClient.class.php b/lib/AlmaClient/AlmaClient.class.php
@@ -544,7 +544,9 @@ public function renew_loan($borr_card, $pin_code, $loan_ids) {
           // successful. Even if this is not the case any error in the current
           // renewal is irrelevant as the loan has previously been renewed so
           // don't report it as such.
-          if ($message == 'isRenewedToday' || $renewable == 'yes') {
+          // Also renewalIsDenied marked as 'no' is considered a successful
+          // renewal.
+          if ($message == 'isRenewedToday' || $renewable == 'yes' || ($message == 'renewalIsDenied' && $renewable == 'no')) {
             $reservations[$id] = TRUE;
           }
           elseif ($message == 'maxNofRenewals') {