Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3018: Issue with message linking #3089

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

f1sh1918
Copy link
Contributor

@f1sh1918 f1sh1918 commented Feb 13, 2025

Short Description

It looks like notifee is blocking some background notification listener on the particular version we used.
Thats why the deeplinking was not executed

Proposed Changes

  • update notifee to latest

Side Effects

  • none

Testing

  1. Close the app
  2. Send a PN via cms
  3. Open the PN and you should be redirected to the correct route
  4. I face the issue that if the app is open the foreground notification push redirects to 404, since the page is not yet ready. I believe this is just a testCMS issue (Push notifications are sent before news item is delivered by the API integreat-cms#3378) and can be solved by increasing the TIMEOUT or using the production cms to test

Note: I will test it on productions cms when i have an account for it.

Resolved Issues

Fixes: #3018
Tested on android and ios


Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS simulator and android real device. Seems to work. On android it did not open the message when the app was in a quit state (force killed). On iOS simulator I only got a notification in the foreground or when opening the app from the background. I did not get a notification in quit state (however, that is most likely due to it being a simulator and not an iOS real device).
I'll create a follow up issue for the quit state issue.
Thanks for the fix!

Copy link
Contributor

@LeandraH LeandraH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thank you! Tested on real iOS

@f1sh1918 f1sh1918 enabled auto-merge February 18, 2025 08:23
@f1sh1918 f1sh1918 merged commit 88903c9 into main Feb 18, 2025
7 checks passed
@f1sh1918 f1sh1918 deleted the 3018-issue-with-message-linking branch February 18, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Message Linking
3 participants