Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2926: Redesign of search feedback in web #3035

Merged

Conversation

LeandraH
Copy link
Contributor

@LeandraH LeandraH commented Jan 9, 2025

Short description

This is the implementation of the redesign of the search feedback in web.

Proposed changes

  • When there are no search results, the text makes it clearer that we also searched in the fallback language, and a suggestion to try a different language.
  • When there are no search results, there is a very clear CTA to open the feedback form if the user thinks there is information missing anyway.
  • The design also calls for the number of search results to disappear if there aren't any but I decided against that so that a screen reader can still yell at someone to stop typing if they already have no results (IGAPP-886: Announce number of search results in screen reader #2352)

Side effects

  • The sad smiley in the search feedback disappears (though I'm not sure that qualifies as a side effect since that's the design)
  • I used German as the hard-coded fallback language in the translations. Should we ever have the app with a different fallback language by going international, we'll have to fix that. I decided to kick that problem down the road because it's not that likely a scenario, and we would probably have to check through the entire app anyway in that case.

Testing

You can switch the app to English and search for "alleinerziehend".

Resolved issues

Partially fixes: #2926


@LeandraH LeandraH marked this pull request as draft January 16, 2025 09:54
@LeandraH LeandraH marked this pull request as ready for review February 4, 2025 11:25
Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

web/src/components/SearchFeedback.tsx Outdated Show resolved Hide resolved
web/src/components/SearchFeedback.tsx Outdated Show resolved Hide resolved
translations/translations.json Outdated Show resolved Hide resolved
…back-native

2926: Redesign search feedback native
Copy link
Contributor

@bahaaTuffaha bahaaTuffaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work .. tested on Firefox and Chrome

Comment on lines +76 to +78
expect(getAllByText(category1.title)).toBeTruthy()
expect(getAllByText(event0.title)).toBeTruthy()
expect(getAllByText(poi0.title)).toBeTruthy()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there duplicate titles in there? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because the search environment in this test is in English but we don't actually have different results (in the test) for English and German search. It's a little annoying but I decided against fixing this because it's only a problem in this exact test, and wouldn't happen in a real environment where the contents for English and German are different without any overlap.

@LeandraH LeandraH merged commit 583c88c into 2926-fallback-language-in-search Feb 18, 2025
5 checks passed
@LeandraH LeandraH deleted the 2926-Redesign-search-feedback-web branch February 18, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants