-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2926: Redesign of search feedback in web #3035
2926: Redesign of search feedback in web #3035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
…back-native 2926: Redesign search feedback native
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work .. tested on Firefox and Chrome
expect(getAllByText(category1.title)).toBeTruthy() | ||
expect(getAllByText(event0.title)).toBeTruthy() | ||
expect(getAllByText(poi0.title)).toBeTruthy() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there duplicate titles in there? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because the search environment in this test is in English but we don't actually have different results (in the test) for English and German search. It's a little annoying but I decided against fixing this because it's only a problem in this exact test, and wouldn't happen in a real environment where the contents for English and German are different without any overlap.
Short description
This is the implementation of the redesign of the search feedback in web.
Proposed changes
Side effects
Testing
You can switch the app to English and search for "alleinerziehend".
Resolved issues
Partially fixes: #2926