-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2558: Upgrade to Xcode 16 #3003
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good so far with Xcode 16.0 |
@LeandraH what is the status on this? Are you still working on it? |
steffenkleinle
approved these changes
Feb 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, building worked fine on xcode 16.1 already even without this actually
f1sh1918
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR upgrades from Xcode 15 to 16. I had been hoping that we could remove the script with the workaround for the duplicate signature files but it's unfortunately still necessary.
Proposed changes
Side effects
Testing
Check out that the iOS build worked here: https://app.circleci.com/pipelines/github/digitalfabrik/integreat-app/12716/workflows/842c2297-e823-414f-93b6-bb3817b4a40b/jobs/68092 (Or trigger another build yourself, if you prefer)
Resolved issues
Does not fix: #2558
Fixes: #2813