Symfony 6 preparations

digital-blueprint · Mar 7, 2024 · 8211c34 · 8211c34
1 parent c6cb78f
commit 8211c34
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/src/Commands/AdvancedlySignCommand.php b/src/Commands/AdvancedlySignCommand.php
@@ -20,16 +20,15 @@ class AdvancedlySignCommand extends Command implements LoggerAwareInterface
 
     protected $api;
 
-    protected static $defaultName = 'dbp:relay:esign:sign:advanced';
-
     public function __construct(SignatureProviderInterface $api)
     {
         parent::__construct();
         $this->api = $api;
     }
 
-    protected function configure()
+    protected function configure(): void
     {
+        $this->setName('dbp:relay:esign:sign:advanced');
         $this->setDescription('Sign a PDF file');
         $this->addArgument('profile-id', InputArgument::REQUIRED, 'Signing profile ID');
         $this->addArgument('input-path', InputArgument::REQUIRED, 'Input PDF file path');

diff --git a/src/Commands/QualifiedlySignCommand.php b/src/Commands/QualifiedlySignCommand.php
@@ -9,6 +9,7 @@
 use Psr\Log\LoggerAwareInterface;
 use Psr\Log\LoggerAwareTrait;
 use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Helper\QuestionHelper;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -21,16 +22,15 @@ class QualifiedlySignCommand extends Command implements LoggerAwareInterface
 
     protected $api;
 
-    protected static $defaultName = 'dbp:relay:esign:sign:qualified';
-
     public function __construct(SignatureProviderInterface $api)
     {
         parent::__construct();
         $this->api = $api;
     }
 
-    protected function configure()
+    protected function configure(): void
     {
+        $this->setName('dbp:relay:esign:sign:qualified');
         $this->setDescription('Sign a PDF file');
         $this->addArgument('profile-id', InputArgument::REQUIRED, 'Signing profile ID');
         $this->addArgument('input-path', InputArgument::REQUIRED, 'Input PDF file path');
@@ -53,6 +53,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $output->writeln("Open the following URL in your browser:\n    ".$url);
         $question = new Question('After confirming your identity please enter the session ID: ');
         $helper = $this->getHelper('question');
+        assert($helper instanceof QuestionHelper);
         $sessionId = $helper->ask($input, $output, $question);
 
         $signedData = $this->api->fetchQualifiedlySignedDocument($sessionId);

diff --git a/src/DbpRelayEsignBundle.php b/src/DbpRelayEsignBundle.php
@@ -9,7 +9,7 @@
 
 class DbpRelayEsignBundle extends Bundle
 {
-    public function build(ContainerBuilder $container)
+    public function build(ContainerBuilder $container): void
     {
     }
 }
diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php
@@ -52,7 +52,7 @@ public function getConfigTreeBuilder(): TreeBuilder
                                     ->end()
                                     ->integerNode('user_text_row')
                                         ->info('The index of the first unset row in the table (starts with 1)')
-                                        ->example(1)
+                                        ->example('1')
                                     ->end()
                                     ->scalarNode('user_text_attach_parent')
                                         ->info('In case there is content "child" will be attached to "parent" at "row" (optional)')
@@ -64,7 +64,7 @@ public function getConfigTreeBuilder(): TreeBuilder
                                     ->end()
                                     ->integerNode('user_text_attach_row')
                                         ->info('In case there is content "child" will be attached to "parent" at "row" (optional)')
-                                        ->example(4)
+                                        ->example('4')
                                     ->end()
                                 ->end()
                             ->end()
@@ -102,7 +102,7 @@ public function getConfigTreeBuilder(): TreeBuilder
                                     ->end()
                                     ->integerNode('user_text_row')
                                         ->info('The index of the first unset row in the table (starts with 1)')
-                                        ->example(1)
+                                        ->example('1')
                                     ->end()
                                     ->scalarNode('user_text_attach_parent')
                                         ->info('In case there is content "child" will be attached to "parent" at "row" (optional)')
@@ -114,7 +114,7 @@ public function getConfigTreeBuilder(): TreeBuilder
                                     ->end()
                                     ->integerNode('user_text_attach_row')
                                         ->info('In case there is content "child" will be attached to "parent" at "row" (optional)')
-                                        ->example(4)
+                                        ->example('4')
                                     ->end()
                                 ->end()
                             ->end()

diff --git a/src/DependencyInjection/DbpRelayEsignExtension.php b/src/DependencyInjection/DbpRelayEsignExtension.php
@@ -14,7 +14,7 @@ class DbpRelayEsignExtension extends ConfigurableExtension
 {
     use ExtensionTrait;
 
-    public function loadInternal(array $mergedConfig, ContainerBuilder $container)
+    public function loadInternal(array $mergedConfig, ContainerBuilder $container): void
     {
         $pathsToHide = [
             '/esign/advancedly-signed-documents/{identifier}',