Skip to content

Commit 5986691

Browse files
authored
Merge pull request #3 from digidentity/hotfix/nokogiri-dependency
Ensure the right nokogiri version
2 parents 9f5cdc1 + ce57808 commit 5986691

File tree

4 files changed

+41
-39
lines changed

4 files changed

+41
-39
lines changed

CHANGELOG.md

+11
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
## 0.8.1 / 2021-08-13
2+
3+
* Version 0.8.0 fixed a bug with newer versions of nokogiri, however due to the way this fix works it breaks compatability with
4+
older versions so we now added `'nokogiri', '~> 1.11'` as dependency
5+
* Update gemspec
6+
7+
## 0.8.0 / 2021-08-12
8+
9+
### WARNING: COMPATABILITY (see 0.8.1)
10+
* [Fix](https://github.com/digidentity/xmlmapper/pull/2) missing namespace when adding a child
11+
112
## 0.7.0
213

314
* Set xml_value with a non canonicalized version

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
Xmlmapper
1+
XmlMapper
22
===========
33

4-
Xmlmapper allows you to parse XML data and convert it quickly and easily into ruby data structures.
4+
XmlMapper allows you to parse XML data and convert it quickly and easily into ruby data structures.
55

66
This project is a fork of the great work done first by
77
[jnunemaker](https://github.com/jnunemaker/happymapper).

lib/xmlmapper/version.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module XmlMapper
2-
VERSION = '0.8.0'.freeze
2+
VERSION = '0.8.1'.freeze
33
end

xmlmapper.gemspec

+27-36
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,36 @@
1-
# -*- encoding: utf-8 -*-
2-
lib = File.expand_path('../lib', __FILE__)
3-
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
4-
require 'xmlmapper/version'
1+
begin
2+
require File.expand_path(File.join(File.dirname(__FILE__), 'lib/xmlmapper/version'))
3+
rescue LoadError
4+
puts 'WARNING: Could not load XmlMapper::VERSION'
5+
end
56

67
Gem::Specification.new do |s|
7-
s.name = %q{xmlmapper}
8-
s.version = ::XmlMapper::VERSION
9-
10-
s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
11-
s.authors = ["Damien Le Berrigaud",
12-
"John Nunemaker",
13-
"David Bolton",
14-
"Roland Swingler",
8+
s.name = 'xmlmapper'
9+
s.version = XmlMapper::VERSION
10+
s.authors = [
11+
'Damien Le Berrigaud',
12+
'John Nunemaker',
13+
'David Bolton',
14+
'Roland Swingler',
1515
"Etienne Vallette d'Osia",
16-
"Franklin Webber"]
16+
'Franklin Webber',
17+
'Benoist Claassen',
18+
'Johnny Dongelmans'
19+
]
1720

18-
s.email = 'bclaassen@digidentity.eu'
19-
s.date = %q{2015-11-23}
20-
s.description = %q{Object to XML Mapping Library, using Nokogiri (fork from John Nunemaker's Happymapper)}
21-
s.extra_rdoc_files = [ "README.md", "CHANGELOG.md" ]
21+
s.email = 'jdongelmans@digidentity.com'
22+
s.homepage = 'https://github.com/digidentity/xmlmapper'
23+
s.description = "Object to XML Mapping Library, using Nokogiri (fork from John Nunemaker's Happymapper)"
24+
s.summary = 'Provides a simple way to map XML to Ruby Objects and back again.'
25+
s.license = 'MIT'
26+
27+
s.require_paths = ['lib']
2228
s.files = `git ls-files -- lib/*`.split("\n")
23-
s.homepage = %q{http://github.com/digidentity/xmlmapper}
24-
s.require_paths = ["lib"]
25-
s.rubygems_version = %q{1.4.1}
26-
s.summary = %q{Provides a simple way to map XML to Ruby Objects and back again.}
27-
s.license = "MIT"
2829
s.test_files = `git ls-files -- spec/*`.split("\n")
30+
s.extra_rdoc_files = %w[README.md CHANGELOG.md]
2931

30-
if s.respond_to? :specification_version then
31-
s.specification_version = 3
32+
s.required_ruby_version = '>= 2.5.0' # copied from nokogiri.gemspec as this should be aligned
3233

33-
if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
34-
s.add_runtime_dependency(%q<nokogiri>, "~> 1.5" )
35-
s.add_development_dependency(%q<rspec>, ["~> 2.8"])
36-
else
37-
s.add_dependency(%q<nokogiri>, "~> 1.5" )
38-
s.add_dependency(%q<rspec>, ["~> 2.8"])
39-
end
40-
else
41-
s.add_dependency(%q<nokogiri>, "~> 1.5" )
42-
s.add_dependency(%q<rspec>, ["~> 2.8"])
43-
end
34+
s.add_runtime_dependency 'nokogiri', '~> 1.11'
35+
s.add_development_dependency 'rspec', '~> 2.8'
4436
end
45-

0 commit comments

Comments
 (0)